diff options
| author | Dmitriy Vyukov <dvyukov@google.com> | 2013-07-31 20:00:33 +0400 |
|---|---|---|
| committer | Dmitriy Vyukov <dvyukov@google.com> | 2013-07-31 20:00:33 +0400 |
| commit | 8679d5f2b5a621099af285587601d9f0c3f9b93b (patch) | |
| tree | f5dee2d5a2ccff79b282c0b668dea37f2b0c05e5 /src/pkg/runtime/traceback_arm.c | |
| parent | 156e8b306d009ef118a4138f34098c8c41976a08 (diff) | |
| download | go-8679d5f2b5a621099af285587601d9f0c3f9b93b.tar.xz | |
cmd/gc: record argument size for all indirect function calls
This is required to properly unwind reflect.methodValueCall/makeFuncStub.
Fixes #5954.
Stats for 'go install std':
61849 total INSTCALL
24655 currently have ArgSize metadata
27278 have ArgSize metadata with this change
godoc size before: 11351888, after: 11364288
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/12163043
Diffstat (limited to 'src/pkg/runtime/traceback_arm.c')
| -rw-r--r-- | src/pkg/runtime/traceback_arm.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/pkg/runtime/traceback_arm.c b/src/pkg/runtime/traceback_arm.c index 563ba28c94..4b9692c076 100644 --- a/src/pkg/runtime/traceback_arm.c +++ b/src/pkg/runtime/traceback_arm.c @@ -102,7 +102,7 @@ runtime·gentraceback(uintptr pc0, uintptr sp0, uintptr lr0, G *gp, int32 skip, // Most functions have a fixed-size argument block, // so we can use metadata about the function f. // Not all, though: there are some variadic functions - // in package runtime, and for those we use call-specific + // in package runtime and reflect, and for those we use call-specific // metadata recorded by f's caller. if(callback != nil || printing) { frame.argp = (byte*)frame.fp + sizeof(uintptr); |