diff options
| author | Russ Cox <rsc@golang.org> | 2013-07-12 00:03:32 -0400 |
|---|---|---|
| committer | Russ Cox <rsc@golang.org> | 2013-07-12 00:03:32 -0400 |
| commit | fb63e4fefbb1325a21f643febc97987c82fcae7a (patch) | |
| tree | f466ebd0309d253308fd2b55a0c3a14b41808f24 /src/pkg/runtime/runtime.h | |
| parent | 3a8845b5259e9b4fa80a43444643ea74f1078286 (diff) | |
| download | go-fb63e4fefbb1325a21f643febc97987c82fcae7a.tar.xz | |
runtime: make cas64 like cas32 and casp
The current cas64 definition hard-codes the x86 behavior
of updating *old with the new value when the cas fails.
This is inconsistent with cas32 and casp.
Make it consistent.
This means that the cas64 uses will be epsilon less efficient
than they might be, because they have to do an unnecessary
memory load on x86. But so be it. Code clarity and consistency
is more important.
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/10909045
Diffstat (limited to 'src/pkg/runtime/runtime.h')
| -rw-r--r-- | src/pkg/runtime/runtime.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/pkg/runtime/runtime.h b/src/pkg/runtime/runtime.h index 6c590be633..49503ab41b 100644 --- a/src/pkg/runtime/runtime.h +++ b/src/pkg/runtime/runtime.h @@ -761,7 +761,7 @@ int32 runtime·write(int32, void*, int32); int32 runtime·close(int32); int32 runtime·mincore(void*, uintptr, byte*); bool runtime·cas(uint32*, uint32, uint32); -bool runtime·cas64(uint64*, uint64*, uint64); +bool runtime·cas64(uint64*, uint64, uint64); bool runtime·casp(void**, void*, void*); // Don't confuse with XADD x86 instruction, // this one is actually 'addx', that is, add-and-fetch. |