diff options
| author | Russ Cox <rsc@golang.org> | 2013-08-05 19:49:02 -0400 |
|---|---|---|
| committer | Russ Cox <rsc@golang.org> | 2013-08-05 19:49:02 -0400 |
| commit | d3066e47b13f3a46ae76a0612abbe25d4d80ddbf (patch) | |
| tree | 62d4576a0d1f6bd6a6f226a0a737a20983da24f8 /src/pkg/runtime/runtime.h | |
| parent | d8e27db39562d2106f0c9cf7518eaa9ade748a4f (diff) | |
| download | go-d3066e47b13f3a46ae76a0612abbe25d4d80ddbf.tar.xz | |
runtime/pprof: test multithreaded profile, remove OS X workarounds
This means that pprof will no longer report profiles on OS X.
That's unfortunate, but the profiles were often wrong and, worse,
it was difficult to tell whether the profile was wrong or not.
The workarounds were making the scheduler more complex,
possibly caused a deadlock (see issue 5519), and did not actually
deliver reliable results.
It may be possible for adventurous users to apply a patch to
their kernels to get working results, or perhaps having no results
will encourage someone to do the work of creating a profiling
thread like on Windows. Issue 6047 has details.
Fixes #5519.
Fixes #6047.
R=golang-dev, bradfitz, r
CC=golang-dev
https://golang.org/cl/12429045
Diffstat (limited to 'src/pkg/runtime/runtime.h')
| -rw-r--r-- | src/pkg/runtime/runtime.h | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/src/pkg/runtime/runtime.h b/src/pkg/runtime/runtime.h index cc38953135..c4beab1b5d 100644 --- a/src/pkg/runtime/runtime.h +++ b/src/pkg/runtime/runtime.h @@ -1043,16 +1043,6 @@ void runtime·ifaceE2I(InterfaceType*, Eface, Iface*); uintptr runtime·memlimit(void); -// If appropriate, ask the operating system to control whether this -// thread should receive profiling signals. This is only necessary on OS X. -// An operating system should not deliver a profiling signal to a -// thread that is not actually executing (what good is that?), but that's -// what OS X prefers to do. When profiling is turned on, we mask -// away the profiling signal when threads go to sleep, so that OS X -// is forced to deliver the signal to a thread that's actually running. -// This is a no-op on other systems. -void runtime·setprof(bool); - // float.c extern float64 runtime·nan; extern float64 runtime·posinf; |
