diff options
| author | Dmitriy Vyukov <dvyukov@google.com> | 2013-01-10 09:57:06 +0400 |
|---|---|---|
| committer | Dmitriy Vyukov <dvyukov@google.com> | 2013-01-10 09:57:06 +0400 |
| commit | f82db7d9e4ccf04b19a087561ab0f521fc36e5b1 (patch) | |
| tree | 17307311faba0dc26fadc8044e0808fc6ee04a4d /src/pkg/runtime/proc.c | |
| parent | 7d403871cb7e319cb1f52ce2ff04c80bdc5ac92a (diff) | |
| download | go-f82db7d9e4ccf04b19a087561ab0f521fc36e5b1.tar.xz | |
runtime: less aggressive per-thread stack segment caching
Introduce global stack segment cache and limit per-thread cache size.
This greatly reduces StackSys memory on workloads that create lots of threads.
benchmark old ns/op new ns/op delta
BenchmarkStackGrowth 665 656 -1.35%
BenchmarkStackGrowth-2 333 328 -1.50%
BenchmarkStackGrowth-4 224 172 -23.21%
BenchmarkStackGrowth-8 124 91 -26.13%
BenchmarkStackGrowth-16 82 47 -41.94%
BenchmarkStackGrowth-32 73 40 -44.79%
BenchmarkStackGrowthDeep 97231 94391 -2.92%
BenchmarkStackGrowthDeep-2 47230 58562 +23.99%
BenchmarkStackGrowthDeep-4 24993 49356 +97.48%
BenchmarkStackGrowthDeep-8 15105 30072 +99.09%
BenchmarkStackGrowthDeep-16 10005 15623 +56.15%
BenchmarkStackGrowthDeep-32 12517 13069 +4.41%
TestStackMem#1,MB 310 12 -96.13%
TestStackMem#2,MB 296 14 -95.27%
TestStackMem#3,MB 479 14 -97.08%
TestStackMem#1,sec 3.22 2.26 -29.81%
TestStackMem#2,sec 2.43 2.15 -11.52%
TestStackMem#3,sec 2.50 2.38 -4.80%
R=sougou, no.smile.face, rsc
CC=golang-dev, msolomon
https://golang.org/cl/7029044
Diffstat (limited to 'src/pkg/runtime/proc.c')
| -rw-r--r-- | src/pkg/runtime/proc.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/pkg/runtime/proc.c b/src/pkg/runtime/proc.c index 80e97795ab..eba0d6456b 100644 --- a/src/pkg/runtime/proc.c +++ b/src/pkg/runtime/proc.c @@ -345,8 +345,6 @@ mcommoninit(M *mp) { mp->id = runtime·sched.mcount++; mp->fastrand = 0x49f6428aUL + mp->id + runtime·cputicks(); - mp->stackalloc = runtime·malloc(sizeof(*mp->stackalloc)); - runtime·FixAlloc_Init(mp->stackalloc, FixedStack, runtime·SysAlloc, nil, nil); if(mp->mcache == nil) mp->mcache = runtime·allocmcache(); |