diff options
| author | Dmitriy Vyukov <dvyukov@google.com> | 2014-08-07 13:04:04 +0400 |
|---|---|---|
| committer | Dmitriy Vyukov <dvyukov@google.com> | 2014-08-07 13:04:04 +0400 |
| commit | cd2f8356ce5515c87710bc7ababfee8fdbdee9c3 (patch) | |
| tree | 4ff5fb4694288807ade4d080b81f5b0e2fe57907 /src/pkg/runtime/malloc.go | |
| parent | 192bccbf33b7493b36989921c8a81ece41904aa5 (diff) | |
| download | go-cd2f8356ce5515c87710bc7ababfee8fdbdee9c3.tar.xz | |
runtime: remove mal/malloc/FlagNoGC/FlagNoInvokeGC
FlagNoGC is unused now.
FlagNoInvokeGC is unneeded as we don't invoke GC
on g0 and when holding locks anyway.
mal/malloc have very few uses and you never remember
the exact set of flags they use and the difference between them.
Moreover, eventually we need to give exact types to all allocations,
something what mal/malloc do not support.
LGTM=khr
R=golang-codereviews, khr
CC=golang-codereviews, rsc
https://golang.org/cl/117580043
Diffstat (limited to 'src/pkg/runtime/malloc.go')
| -rw-r--r-- | src/pkg/runtime/malloc.go | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/src/pkg/runtime/malloc.go b/src/pkg/runtime/malloc.go index 81769573c9..e7f23889af 100644 --- a/src/pkg/runtime/malloc.go +++ b/src/pkg/runtime/malloc.go @@ -11,8 +11,7 @@ import ( const ( flagNoScan = 1 << 0 // GC doesn't have to scan object flagNoProfiling = 1 << 1 // must not profile - flagNoZero = 1 << 3 // don't zero memory - flagNoInvokeGC = 1 << 4 // don't invoke GC + flagNoZero = 1 << 2 // don't zero memory kindArray = 17 kindFunc = 19 @@ -198,7 +197,7 @@ func gomallocgc(size uintptr, typ *_type, flags int) unsafe.Pointer { releasem(mp) - if flags&flagNoInvokeGC == 0 && memstats.heap_alloc >= memstats.next_gc { + if memstats.heap_alloc >= memstats.next_gc { gogc(0) } |