diff options
| author | Marko Tiikkaja <marko@joh.to> | 2013-12-26 11:27:18 -0800 |
|---|---|---|
| committer | Brad Fitzpatrick <bradfitz@golang.org> | 2013-12-26 11:27:18 -0800 |
| commit | 0d12e24ebb037202c3324c230e075f1e448f6f34 (patch) | |
| tree | 64e274476326c85550ff485b999dfee77fd4f9c0 /src/pkg/database/sql/sql_test.go | |
| parent | 59583b09f3165dedd46800f46000c83c92a7faba (diff) | |
| download | go-0d12e24ebb037202c3324c230e075f1e448f6f34.tar.xz | |
database/sql: Use all connections in pool
The last connection in the pool was not being handed out correctly.
R=golang-codereviews, gobot, bradfitz
CC=golang-codereviews
https://golang.org/cl/40410043
Diffstat (limited to 'src/pkg/database/sql/sql_test.go')
| -rw-r--r-- | src/pkg/database/sql/sql_test.go | 23 |
1 files changed, 23 insertions, 0 deletions
diff --git a/src/pkg/database/sql/sql_test.go b/src/pkg/database/sql/sql_test.go index aac36f87d3..a0a20df6f8 100644 --- a/src/pkg/database/sql/sql_test.go +++ b/src/pkg/database/sql/sql_test.go @@ -1033,6 +1033,29 @@ func TestMaxOpenConns(t *testing.T) { } } +func TestSingleOpenConn(t *testing.T) { + db := newTestDB(t, "people") + defer closeDB(t, db) + + db.SetMaxOpenConns(1) + + rows, err := db.Query("SELECT|people|name|") + if err != nil { + t.Fatal(err) + } + if err = rows.Close(); err != nil { + t.Fatal(err) + } + // shouldn't deadlock + rows, err = db.Query("SELECT|people|name|") + if err != nil { + t.Fatal(err) + } + if err = rows.Close(); err != nil { + t.Fatal(err) + } +} + // golang.org/issue/5323 func TestStmtCloseDeps(t *testing.T) { if testing.Short() { |