diff options
| author | Bryan C. Mills <bcmills@google.com> | 2022-09-29 09:33:07 -0400 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2022-09-29 18:49:15 +0000 |
| commit | ce3a5c0d1036bea6d0abb9ff638f3a5382e428ee (patch) | |
| tree | 76c65cfe1a23394aec19daf16807c5b8828dabd7 /src/os/exec | |
| parent | 4a0a2b33dfa3c99250efa222439f2c27d6780e4a (diff) | |
| download | go-ce3a5c0d1036bea6d0abb9ff638f3a5382e428ee.tar.xz | |
os/exec: avoid leaking a process in TestDoubleStartLeavesPipesOpen
Updates #52580.
For #50436.
Change-Id: I0929055ffca1ca429f6ebec7d877f4268bd1fda2
Reviewed-on: https://go-review.googlesource.com/c/go/+/436656
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Bryan Mills <bcmills@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Benny Siegert <bsiegert@gmail.com>
Diffstat (limited to 'src/os/exec')
| -rw-r--r-- | src/os/exec/exec_test.go | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/src/os/exec/exec_test.go b/src/os/exec/exec_test.go index 07ac0cf3d4..822f606d66 100644 --- a/src/os/exec/exec_test.go +++ b/src/os/exec/exec_test.go @@ -1108,9 +1108,16 @@ func TestDoubleStartLeavesPipesOpen(t *testing.T) { if err != nil { t.Fatal(err) } + if err := cmd.Start(); err != nil { t.Fatal(err) } + t.Cleanup(func() { + if err := cmd.Wait(); err != nil { + t.Error(err) + } + }) + if err := cmd.Start(); err == nil || !strings.HasSuffix(err.Error(), "already started") { t.Fatalf("second call to Start returned a nil; want an 'already started' error") } |