diff options
| author | Cherry Zhang <cherryyz@google.com> | 2019-10-04 16:55:52 -0400 |
|---|---|---|
| committer | Cherry Zhang <cherryyz@google.com> | 2019-10-04 16:55:52 -0400 |
| commit | b0d930577ebe86d0dbd6d3f4bf551a4e4ff1fcde (patch) | |
| tree | c1382943d8874ef6f278b1b49d38b4a5090993a8 /src/os/exec | |
| parent | e63c1df34856fbf61f72fef84f810cf3306ec204 (diff) | |
| parent | c450ace12c657e3953d79975c04f51605395cd50 (diff) | |
| download | go-b0d930577ebe86d0dbd6d3f4bf551a4e4ff1fcde.tar.xz | |
[dev.link] all: merge branch 'master' into dev.link
Weekly merge.
Change-Id: I98c6121f04f347df2788ac5eaf99afad5da4a039
Diffstat (limited to 'src/os/exec')
| -rw-r--r-- | src/os/exec/exec.go | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/os/exec/exec.go b/src/os/exec/exec.go index 17ef003eca..19c7e2406a 100644 --- a/src/os/exec/exec.go +++ b/src/os/exec/exec.go @@ -606,8 +606,8 @@ func (c *closeOnce) close() { // standard output when the command starts. // // Wait will close the pipe after seeing the command exit, so most callers -// need not close the pipe themselves; however, an implication is that -// it is incorrect to call Wait before all reads from the pipe have completed. +// need not close the pipe themselves. It is thus incorrect to call Wait +// before all reads from the pipe have completed. // For the same reason, it is incorrect to call Run when using StdoutPipe. // See the example for idiomatic usage. func (c *Cmd) StdoutPipe() (io.ReadCloser, error) { @@ -631,8 +631,8 @@ func (c *Cmd) StdoutPipe() (io.ReadCloser, error) { // standard error when the command starts. // // Wait will close the pipe after seeing the command exit, so most callers -// need not close the pipe themselves; however, an implication is that -// it is incorrect to call Wait before all reads from the pipe have completed. +// need not close the pipe themselves. It is thus incorrect to call Wait +// before all reads from the pipe have completed. // For the same reason, it is incorrect to use Run when using StderrPipe. // See the StdoutPipe example for idiomatic usage. func (c *Cmd) StderrPipe() (io.ReadCloser, error) { |
