diff options
| author | Bryan C. Mills <bcmills@google.com> | 2022-10-05 15:21:06 -0400 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2022-10-06 19:09:18 +0000 |
| commit | 515e3de2999b23da28e6d15ac485bfdd299ec83a (patch) | |
| tree | c0ec299f24c09bb1e345d06cbf07e7fb58be27a4 /src/os/exec/exec_windows_test.go | |
| parent | 274d3a06f7331740b849e20cff1d1c1ab84dd0e0 (diff) | |
| download | go-515e3de2999b23da28e6d15ac485bfdd299ec83a.tar.xz | |
os/exec: parallelize more tests
This cuts the wall duration for 'go test os/exec' and
'go test -race os/exec' roughly in half on my machine,
which is an even more significant speedup with a high '-count'.
For better or for worse, it may also increase the repro rate
of #34988.
Tests that use Setenv or Chdir or check for FDs opened during the test
still cannot be parallelized, but they are only a few of those.
Change-Id: I8d284d8bff05787853f825ef144aeb7a4126847f
Reviewed-on: https://go-review.googlesource.com/c/go/+/439196
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
Diffstat (limited to 'src/os/exec/exec_windows_test.go')
| -rw-r--r-- | src/os/exec/exec_windows_test.go | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/src/os/exec/exec_windows_test.go b/src/os/exec/exec_windows_test.go index 35ae0b0b8a..9dec72b3e1 100644 --- a/src/os/exec/exec_windows_test.go +++ b/src/os/exec/exec_windows_test.go @@ -33,6 +33,8 @@ func cmdPipeHandle(args ...string) { } func TestPipePassing(t *testing.T) { + t.Parallel() + r, w, err := os.Pipe() if err != nil { t.Error(err) @@ -60,6 +62,8 @@ func TestPipePassing(t *testing.T) { } func TestNoInheritHandles(t *testing.T) { + t.Parallel() + cmd := exec.Command("cmd", "/c exit 88") cmd.SysProcAttr = &syscall.SysProcAttr{NoInheritHandles: true} err := cmd.Run() @@ -76,6 +80,7 @@ func TestNoInheritHandles(t *testing.T) { // with a copy of the parent's SYSTEMROOT. // (See issue 25210.) func TestChildCriticalEnv(t *testing.T) { + t.Parallel() cmd := helperCommand(t, "echoenv", "SYSTEMROOT") // Explicitly remove SYSTEMROOT from the command's environment. |