aboutsummaryrefslogtreecommitdiff
path: root/src/os/exec/exec.go
diff options
context:
space:
mode:
authorDavid Chase <drchase@google.com>2019-07-29 16:23:31 -0400
committerDavid Chase <drchase@google.com>2019-10-04 20:41:52 +0000
commitc450ace12c657e3953d79975c04f51605395cd50 (patch)
tree76faeebeefa1d8b68f66f737cedee8438fd33f5d /src/os/exec/exec.go
parent9a926911fea73017a25d6d38035946c59cf1b047 (diff)
downloadgo-c450ace12c657e3953d79975c04f51605395cd50.tar.xz
cmd/compile: remove statement marks from secondary calls
Calls are code-generated in an alternate path that inherits its positions from values, not from *SSAGenState. The default position on *SSAGenState was marked as not-a-statement, but this was not applied to the value itself, leading to spurious "is statement" marks in the output (convention: after code generation in the compiler, everything is either definitely a statement or definitely not a statement, nothing is in the undetermined state). This CL causes a 35 statement regression in ssa/stmtlines_test. This is down from the earlier 150 because of all the other CLs preceding this one that deal with the root causes of the missing lines (repeated lines on nested calls hid missing lines). This also removes some line repeats from ssa/debug_test. Change-Id: Ie9a507bd5447e906b35bbd098e3295211df2ae01 Reviewed-on: https://go-review.googlesource.com/c/go/+/188018 Run-TryBot: David Chase <drchase@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Jeremy Faller <jeremy@golang.org>
Diffstat (limited to 'src/os/exec/exec.go')
0 files changed, 0 insertions, 0 deletions