diff options
| author | Josh Bleecher Snyder <josharian@gmail.com> | 2016-04-12 14:04:01 -0700 |
|---|---|---|
| committer | Josh Bleecher Snyder <josharian@gmail.com> | 2016-04-12 21:07:58 +0000 |
| commit | 6fb8bf9d7940b2e2a90249e1894ad4e3d24fd3e7 (patch) | |
| tree | 2d935d28894b30229cecd3471beb4702dc1c337a /src/net/timeout_test.go | |
| parent | 022548cfe82915e5bf14ce7cb28f3ec651550662 (diff) | |
| download | go-6fb8bf9d7940b2e2a90249e1894ad4e3d24fd3e7.tar.xz | |
net: make two tests not parallel
Running
stress -p 1 go test -short std
on a heavily loaded machine causes net timeouts
every 15 or 20 runs.
Making these tests not run in parallel helps.
With this change, I haven’t seen a single failure
in over 100 runs.
Fixes #14986
Change-Id: Ibaa14869ce8d95b00266aee94d62d195927ede68
Reviewed-on: https://go-review.googlesource.com/21905
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Diffstat (limited to 'src/net/timeout_test.go')
| -rw-r--r-- | src/net/timeout_test.go | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/src/net/timeout_test.go b/src/net/timeout_test.go index 3ea0ec1ebd..86010927b3 100644 --- a/src/net/timeout_test.go +++ b/src/net/timeout_test.go @@ -112,7 +112,6 @@ var dialTimeoutMaxDurationTests = []struct { } func TestDialTimeoutMaxDuration(t *testing.T) { - t.Parallel() if runtime.GOOS == "openbsd" { testenv.SkipFlaky(t, 15157) } @@ -315,8 +314,6 @@ var readTimeoutTests = []struct { } func TestReadTimeout(t *testing.T) { - t.Parallel() - switch runtime.GOOS { case "plan9": t.Skipf("not supported on %s", runtime.GOOS) |