diff options
| author | Bryan Mills <bcmills@google.com> | 2021-12-07 20:34:46 +0000 |
|---|---|---|
| committer | Bryan Mills <bcmills@google.com> | 2021-12-08 15:31:54 +0000 |
| commit | 2c85fcd47d6804d94a1fa4da65f756200ecf57a8 (patch) | |
| tree | 53de00f9242f6bfb0a055e5a16d6387b4d113360 /src/net/server_test.go | |
| parent | 9fe77de3c198848b972915245e41ff26439b08aa (diff) | |
| download | go-2c85fcd47d6804d94a1fa4da65f756200ecf57a8.tar.xz | |
Revert "net: in (*netFD).dial, use the passed in local address if getsockname fails"
This reverts CL 366536
Reason for revert: may have caused #50033 due to an invalid or partially-populated *TCPAddr
Fixes #50033
Change-Id: Ia29ca4116503dba65d56e89caa46ba1c848d421a
Reviewed-on: https://go-review.googlesource.com/c/go/+/369982
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Diffstat (limited to 'src/net/server_test.go')
| -rw-r--r-- | src/net/server_test.go | 10 |
1 files changed, 1 insertions, 9 deletions
diff --git a/src/net/server_test.go b/src/net/server_test.go index b69cd29289..33d33b0337 100644 --- a/src/net/server_test.go +++ b/src/net/server_test.go @@ -200,17 +200,9 @@ func TestUnixAndUnixpacketServer(t *testing.T) { if c == nil { panic("Dial returned a nil Conn") } - rc := reflect.ValueOf(c) - if rc.IsNil() { + if rc := reflect.ValueOf(c); rc.Kind() == reflect.Pointer && rc.IsNil() { panic(fmt.Sprintf("Dial returned a nil %T", c)) } - fd := rc.Elem().FieldByName("fd") - if fd.IsNil() { - panic(fmt.Sprintf("Dial returned a %T with a nil fd", c)) - } - if addr := fd.Elem().FieldByName("laddr"); addr.IsNil() { - panic(fmt.Sprintf("Dial returned a %T whose fd has a nil laddr", c)) - } addr := c.LocalAddr() if addr == nil { panic(fmt.Sprintf("(%T).LocalAddr returned a nil Addr", c)) |