diff options
| author | Damien Neil <dneil@google.com> | 2022-09-02 14:48:28 -0700 |
|---|---|---|
| committer | Damien Neil <dneil@google.com> | 2022-09-19 17:14:09 +0000 |
| commit | e7312b1005e77633a4fbd3a5cbb371aef45b0867 (patch) | |
| tree | 315db16f8b3f6f6de2897f2be16c70d5a115ca22 /src/net/http | |
| parent | d8e6ed32622b692c79a4db42e878921e1d3f16a8 (diff) | |
| download | go-e7312b1005e77633a4fbd3a5cbb371aef45b0867.tar.xz | |
net/http: correctly test for leading header spaces in TestReadRequest_Bad
TestReadRequest_Bad's tests for leading whitespace in the first header
were also exercising the test verifying that a HEAD request has no
Content-Length. Also, the test intended to test a leading tab was
actually testing for a leading \t (literal backslash, literal t).
Change-Id: I05b46d05851b49bf75f1d1257c421b953b66ea9c
Reviewed-on: https://go-review.googlesource.com/c/go/+/428134
Reviewed-by: Cherry Mui <cherryyz@google.com>
Run-TryBot: Damien Neil <dneil@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Diffstat (limited to 'src/net/http')
| -rw-r--r-- | src/net/http/readrequest_test.go | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/src/net/http/readrequest_test.go b/src/net/http/readrequest_test.go index a6a12a0ddd..ba5cf4a261 100644 --- a/src/net/http/readrequest_test.go +++ b/src/net/http/readrequest_test.go @@ -455,12 +455,10 @@ Host: foo Content-Length: 5`)}, // golang.org/issue/22464 - {"leading_space_in_header", reqBytes(`HEAD / HTTP/1.1 - Host: foo -Content-Length: 5`)}, - {"leading_tab_in_header", reqBytes(`HEAD / HTTP/1.1 -\tHost: foo -Content-Length: 5`)}, + {"leading_space_in_header", reqBytes(`GET / HTTP/1.1 + Host: foo`)}, + {"leading_tab_in_header", reqBytes(`GET / HTTP/1.1 +` + "\t" + `Host: foo`)}, } func TestReadRequest_Bad(t *testing.T) { |