diff options
| author | cui fliter <imcusg@gmail.com> | 2022-09-08 09:26:37 +0000 |
|---|---|---|
| committer | Damien Neil <dneil@google.com> | 2022-09-09 18:42:57 +0000 |
| commit | b244b89d560051f8d4c4c2b90680477ec05f76c3 (patch) | |
| tree | 86c65766dc6321f6eaa917c70bffcdc64fc8f472 /src/net/http | |
| parent | e509452727b469d89a3fc4a7d1cbf9d3f110efee (diff) | |
| download | go-b244b89d560051f8d4c4c2b90680477ec05f76c3.tar.xz | |
net/http: convert allowQuerySemicolonsInUse to atomic type
For #53821
Change-Id: I135783bd5472011f6a74d2f5ee34ce96ff49ad2b
GitHub-Last-Rev: 4da2d67ff3d19424c306e1de6a4152fc93785a97
GitHub-Pull-Request: golang/go#54863
Reviewed-on: https://go-review.googlesource.com/c/go/+/428336
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Diffstat (limited to 'src/net/http')
| -rw-r--r-- | src/net/http/server.go | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/net/http/server.go b/src/net/http/server.go index 3d427e5ae4..d96283ccc4 100644 --- a/src/net/http/server.go +++ b/src/net/http/server.go @@ -2905,12 +2905,12 @@ func (sh serverHandler) ServeHTTP(rw ResponseWriter, req *Request) { } if req.URL != nil && strings.Contains(req.URL.RawQuery, ";") { - var allowQuerySemicolonsInUse int32 + var allowQuerySemicolonsInUse atomic.Bool req = req.WithContext(context.WithValue(req.Context(), silenceSemWarnContextKey, func() { - atomic.StoreInt32(&allowQuerySemicolonsInUse, 1) + allowQuerySemicolonsInUse.Store(true) })) defer func() { - if atomic.LoadInt32(&allowQuerySemicolonsInUse) == 0 { + if !allowQuerySemicolonsInUse.Load() { sh.srv.logf("http: URL query contains semicolon, which is no longer a supported separator; parts of the query may be stripped when parsed; see golang.org/issue/25192") } }() |