aboutsummaryrefslogtreecommitdiff
path: root/src/net/http
diff options
context:
space:
mode:
authorBrad Fitzpatrick <bradfitz@golang.org>2015-07-10 17:17:11 -0600
committerBrad Fitzpatrick <bradfitz@golang.org>2015-07-11 14:36:33 +0000
commit2ae77376f7ab6f4161944570cb1b3a38ff47c5cd (patch)
tree45ae2231b42b5ff87160dece9f61b1e0fb332bca /src/net/http
parentf96fa06d14dfb41d987ae5372084e593ac535b13 (diff)
downloadgo-2ae77376f7ab6f4161944570cb1b3a38ff47c5cd.tar.xz
all: link to https instead of http
The one in misc/makerelease/makerelease.go is particularly bad and probably warrants rotating our keys. I didn't update old weekly notes, and reverted some changes involving test code for now, since we're late in the Go 1.5 freeze. Otherwise, the rest are all auto-generated changes, and all manually reviewed. Change-Id: Ia2753576ab5d64826a167d259f48a2f50508792d Reviewed-on: https://go-review.googlesource.com/12048 Reviewed-by: Rob Pike <r@golang.org>
Diffstat (limited to 'src/net/http')
-rw-r--r--src/net/http/client.go2
-rw-r--r--src/net/http/client_test.go4
-rw-r--r--src/net/http/cookie.go2
-rw-r--r--src/net/http/httputil/reverseproxy_test.go2
-rw-r--r--src/net/http/serve_test.go14
-rw-r--r--src/net/http/server.go2
-rw-r--r--src/net/http/transport.go4
-rw-r--r--src/net/http/transport_test.go18
8 files changed, 24 insertions, 24 deletions
diff --git a/src/net/http/client.go b/src/net/http/client.go
index 02ac85a1d7..7f2fbb4678 100644
--- a/src/net/http/client.go
+++ b/src/net/http/client.go
@@ -423,7 +423,7 @@ func (c *Client) doFollowingRedirects(ireq *Request, shouldRedirect func(int) bo
if redirectFailed {
// Special case for Go 1 compatibility: return both the response
// and an error if the CheckRedirect function failed.
- // See http://golang.org/issue/3795
+ // See https://golang.org/issue/3795
return resp, urlErr
}
diff --git a/src/net/http/client_test.go b/src/net/http/client_test.go
index 10829a7790..7b524d381b 100644
--- a/src/net/http/client_test.go
+++ b/src/net/http/client_test.go
@@ -258,7 +258,7 @@ func TestClientRedirects(t *testing.T) {
t.Errorf("with redirects forbidden, expected a *url.Error with our 'no redirects allowed' error inside; got %#v (%q)", err, err)
}
if res == nil {
- t.Fatalf("Expected a non-nil Response on CheckRedirect failure (http://golang.org/issue/3795)")
+ t.Fatalf("Expected a non-nil Response on CheckRedirect failure (https://golang.org/issue/3795)")
}
res.Body.Close()
if res.Header.Get("Location") == "" {
@@ -739,7 +739,7 @@ func TestResponseSetsTLSConnectionState(t *testing.T) {
}
}
-// Verify Response.ContentLength is populated. http://golang.org/issue/4126
+// Verify Response.ContentLength is populated. https://golang.org/issue/4126
func TestClientHeadContentLength(t *testing.T) {
defer afterTest(t)
ts := httptest.NewServer(HandlerFunc(func(w ResponseWriter, r *Request) {
diff --git a/src/net/http/cookie.go b/src/net/http/cookie.go
index cf7a3dbe5b..648709dd99 100644
--- a/src/net/http/cookie.go
+++ b/src/net/http/cookie.go
@@ -304,7 +304,7 @@ func sanitizeCookieName(n string) string {
// We loosen this as spaces and commas are common in cookie values
// but we produce a quoted cookie-value in when value starts or ends
// with a comma or space.
-// See http://golang.org/issue/7243 for the discussion.
+// See https://golang.org/issue/7243 for the discussion.
func sanitizeCookieValue(v string) string {
v = sanitizeOrWarn("Cookie.Value", validCookieValueByte, v)
if len(v) == 0 {
diff --git a/src/net/http/httputil/reverseproxy_test.go b/src/net/http/httputil/reverseproxy_test.go
index 758f184962..25947e6a8a 100644
--- a/src/net/http/httputil/reverseproxy_test.go
+++ b/src/net/http/httputil/reverseproxy_test.go
@@ -226,7 +226,7 @@ func TestReverseProxyFlushInterval(t *testing.T) {
func TestReverseProxyCancellation(t *testing.T) {
if runtime.GOOS == "plan9" {
- t.Skip("skipping test; see http://golang.org/issue/9554")
+ t.Skip("skipping test; see https://golang.org/issue/9554")
}
const backendResponse = "I am the backend"
diff --git a/src/net/http/serve_test.go b/src/net/http/serve_test.go
index 6c3c65641d..b28e4063c4 100644
--- a/src/net/http/serve_test.go
+++ b/src/net/http/serve_test.go
@@ -421,7 +421,7 @@ func TestServeMuxHandlerRedirects(t *testing.T) {
}
}
-// Tests for http://golang.org/issue/900
+// Tests for https://golang.org/issue/900
func TestMuxRedirectLeadingSlashes(t *testing.T) {
paths := []string{"//foo.txt", "///foo.txt", "/../../foo.txt"}
for _, path := range paths {
@@ -448,7 +448,7 @@ func TestMuxRedirectLeadingSlashes(t *testing.T) {
func TestServerTimeouts(t *testing.T) {
if runtime.GOOS == "plan9" {
- t.Skip("skipping test; see http://golang.org/issue/7237")
+ t.Skip("skipping test; see https://golang.org/issue/7237")
}
defer afterTest(t)
reqNum := 0
@@ -527,7 +527,7 @@ func TestServerTimeouts(t *testing.T) {
// request) that will never happen.
func TestOnlyWriteTimeout(t *testing.T) {
if runtime.GOOS == "plan9" {
- t.Skip("skipping test; see http://golang.org/issue/7237")
+ t.Skip("skipping test; see https://golang.org/issue/7237")
}
defer afterTest(t)
var conn net.Conn
@@ -882,7 +882,7 @@ func TestHeadResponses(t *testing.T) {
func TestTLSHandshakeTimeout(t *testing.T) {
if runtime.GOOS == "plan9" {
- t.Skip("skipping test; see http://golang.org/issue/7237")
+ t.Skip("skipping test; see https://golang.org/issue/7237")
}
defer afterTest(t)
ts := httptest.NewUnstartedServer(HandlerFunc(func(w ResponseWriter, r *Request) {}))
@@ -1744,7 +1744,7 @@ func TestRequestBodyLimit(t *testing.T) {
// side of their TCP connection, the server doesn't send a 400 Bad Request.
func TestClientWriteShutdown(t *testing.T) {
if runtime.GOOS == "plan9" {
- t.Skip("skipping test; see http://golang.org/issue/7237")
+ t.Skip("skipping test; see https://golang.org/issue/7237")
}
defer afterTest(t)
ts := httptest.NewServer(HandlerFunc(func(w ResponseWriter, r *Request) {}))
@@ -1799,7 +1799,7 @@ func TestServerBufferedChunking(t *testing.T) {
// Tests that the server flushes its response headers out when it's
// ignoring the response body and waits a bit before forcefully
// closing the TCP connection, causing the client to get a RST.
-// See http://golang.org/issue/3595
+// See https://golang.org/issue/3595
func TestServerGracefulClose(t *testing.T) {
defer afterTest(t)
ts := httptest.NewServer(HandlerFunc(func(w ResponseWriter, r *Request) {
@@ -2291,7 +2291,7 @@ func TestDoubleHijack(t *testing.T) {
<-conn.closec
}
-// http://golang.org/issue/5955
+// https://golang.org/issue/5955
// Note that this does not test the "request too large"
// exit path from the http server. This is intentional;
// not sending Connection: close is just a minor wire
diff --git a/src/net/http/server.go b/src/net/http/server.go
index bac3e04647..882c352144 100644
--- a/src/net/http/server.go
+++ b/src/net/http/server.go
@@ -1183,7 +1183,7 @@ var _ closeWriter = (*net.TCPConn)(nil)
// pause for a bit, hoping the client processes it before any
// subsequent RST.
//
-// See http://golang.org/issue/3595
+// See https://golang.org/issue/3595
func (c *conn) closeWriteAndWait() {
c.finalFlush()
if tcp, ok := c.rwc.(closeWriter); ok {
diff --git a/src/net/http/transport.go b/src/net/http/transport.go
index 8544fe378d..41fc6d0e62 100644
--- a/src/net/http/transport.go
+++ b/src/net/http/transport.go
@@ -1134,11 +1134,11 @@ func (pc *persistConn) roundTrip(req *transportRequest) (resp *Response, err err
// Note that we don't request this for HEAD requests,
// due to a bug in nginx:
// http://trac.nginx.org/nginx/ticket/358
- // http://golang.org/issue/5522
+ // https://golang.org/issue/5522
//
// We don't request gzip if the request is for a range, since
// auto-decoding a portion of a gzipped document will just fail
- // anyway. See http://golang.org/issue/8923
+ // anyway. See https://golang.org/issue/8923
requestedGzip = true
req.extraHeaders().Set("Accept-Encoding", "gzip")
}
diff --git a/src/net/http/transport_test.go b/src/net/http/transport_test.go
index 0eaf70da5d..d399552e47 100644
--- a/src/net/http/transport_test.go
+++ b/src/net/http/transport_test.go
@@ -486,7 +486,7 @@ func TestTransportServerClosingUnexpectedly(t *testing.T) {
}
}
-// Test for http://golang.org/issue/2616 (appropriate issue number)
+// Test for https://golang.org/issue/2616 (appropriate issue number)
// This fails pretty reliably with GOMAXPROCS=100 or something high.
func TestStressSurpriseServerCloses(t *testing.T) {
defer afterTest(t)
@@ -876,7 +876,7 @@ func TestTransportGzipShort(t *testing.T) {
// tests that persistent goroutine connections shut down when no longer desired.
func TestTransportPersistConnLeak(t *testing.T) {
if runtime.GOOS == "plan9" {
- t.Skip("skipping test; see http://golang.org/issue/7237")
+ t.Skip("skipping test; see https://golang.org/issue/7237")
}
defer afterTest(t)
gotReqCh := make(chan bool)
@@ -945,7 +945,7 @@ func TestTransportPersistConnLeak(t *testing.T) {
// request.ContentLength is explicitly short
func TestTransportPersistConnLeakShortBody(t *testing.T) {
if runtime.GOOS == "plan9" {
- t.Skip("skipping test; see http://golang.org/issue/7237")
+ t.Skip("skipping test; see https://golang.org/issue/7237")
}
defer afterTest(t)
ts := httptest.NewServer(HandlerFunc(func(w ResponseWriter, r *Request) {
@@ -984,7 +984,7 @@ func TestTransportPersistConnLeakShortBody(t *testing.T) {
}
}
-// This used to crash; http://golang.org/issue/3266
+// This used to crash; https://golang.org/issue/3266
func TestTransportIdleConnCrash(t *testing.T) {
defer afterTest(t)
tr := &Transport{}
@@ -1066,7 +1066,7 @@ func TestIssue3595(t *testing.T) {
}
}
-// From http://golang.org/issue/4454 ,
+// From https://golang.org/issue/4454 ,
// "client fails to handle requests with no body and chunked encoding"
func TestChunkedNoContent(t *testing.T) {
defer afterTest(t)
@@ -1153,7 +1153,7 @@ func TestTransportConcurrency(t *testing.T) {
func TestIssue4191_InfiniteGetTimeout(t *testing.T) {
if runtime.GOOS == "plan9" {
- t.Skip("skipping test; see http://golang.org/issue/7237")
+ t.Skip("skipping test; see https://golang.org/issue/7237")
}
defer afterTest(t)
const debug = false
@@ -1217,7 +1217,7 @@ func TestIssue4191_InfiniteGetTimeout(t *testing.T) {
func TestIssue4191_InfiniteGetToPutTimeout(t *testing.T) {
if runtime.GOOS == "plan9" {
- t.Skip("skipping test; see http://golang.org/issue/7237")
+ t.Skip("skipping test; see https://golang.org/issue/7237")
}
defer afterTest(t)
const debug = false
@@ -1533,7 +1533,7 @@ func TestCancelRequestWithChannelBeforeDo(t *testing.T) {
defer close(unblockc)
// Don't interfere with the next test on plan9.
- // Cf. http://golang.org/issues/11476
+ // Cf. https://golang.org/issues/11476
if runtime.GOOS == "plan9" {
defer time.Sleep(500 * time.Millisecond)
}
@@ -2257,7 +2257,7 @@ func (f closerFunc) Close() error { return f() }
// Issue 6981
func TestTransportClosesBodyOnError(t *testing.T) {
if runtime.GOOS == "plan9" {
- t.Skip("skipping test; see http://golang.org/issue/7782")
+ t.Skip("skipping test; see https://golang.org/issue/7782")
}
defer afterTest(t)
readBody := make(chan error, 1)