diff options
| author | Damien Neil <dneil@google.com> | 2025-03-06 17:33:27 -0800 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2025-04-15 15:55:28 -0700 |
| commit | 2869d55366a55d6a29a166523ac2383d0b2291df (patch) | |
| tree | 60cf7ef0fa78d7f2c0f9cbaae539ac5ab173c2f3 /src/net/http | |
| parent | 64371adcf4f431adc1f6afab4d7e61bb9b5eff72 (diff) | |
| download | go-2869d55366a55d6a29a166523ac2383d0b2291df.tar.xz | |
net/http: test intended behavior in TestClientInsecureTransport
This test wasn't testing the HTTP/2 case, because it didn't
set NextProtos in the tls.Config.
Set "Connection: close" on requests to make sure each request
gets a new connection.
Change-Id: I1ef470e7433a602ce88da7bd7eeec502687ea857
Reviewed-on: https://go-review.googlesource.com/c/go/+/655676
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Sean Liao <sean@liao.dev>
Auto-Submit: Damien Neil <dneil@google.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
Diffstat (limited to 'src/net/http')
| -rw-r--r-- | src/net/http/client_test.go | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/src/net/http/client_test.go b/src/net/http/client_test.go index 1ce9539528..ec5ac7ffeb 100644 --- a/src/net/http/client_test.go +++ b/src/net/http/client_test.go @@ -834,8 +834,11 @@ func testClientInsecureTransport(t *testing.T, mode testMode) { for _, insecure := range []bool{true, false} { c.Transport.(*Transport).TLSClientConfig = &tls.Config{ InsecureSkipVerify: insecure, + NextProtos: cst.tr.TLSClientConfig.NextProtos, } - res, err := c.Get(ts.URL) + req, _ := NewRequest("GET", ts.URL, nil) + req.Header.Set("Connection", "close") // don't reuse this connection + res, err := c.Do(req) if (err == nil) != insecure { t.Errorf("insecure=%v: got unexpected err=%v", insecure, err) } |