diff options
| author | Kevin Burke <kevin@burke.dev> | 2024-03-21 15:59:30 -0700 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2024-03-25 18:23:25 +0000 |
| commit | 13a1f39ade1fe90124b2ea5b7e28c4bcb34041ca (patch) | |
| tree | e5aa71c220ad4f0d5347dbfb30bf472017b439ad /src/net/http | |
| parent | 25aa45afcf40ff6c699b47bad0cb609bba84da12 (diff) | |
| download | go-13a1f39ade1fe90124b2ea5b7e28c4bcb34041ca.tar.xz | |
log/slog: use plain string concatenation for Attr.String
Plain string concatenation with the plus operator for Attr.String is
much faster than invoking fmt.Sprintf. Added a benchmark to verify
this (just running on my Mac with stuff in the background but should
be sufficient to demonstrate the effect).
name old time/op new time/op delta
AttrString-8 1.24µs ± 3% 0.43µs ± 0% -65.17% (p=0.000 n=20+17)
name old alloc/op new alloc/op delta
AttrString-8 432B ± 0% 152B ± 0% ~ (p=1.000 n=1+1)
name old allocs/op new allocs/op delta
AttrString-8 30.0 ± 0% 16.0 ± 0% ~ (p=1.000 n=1+1)
Change-Id: I18ac91cbff1047d168b51a595601e36b5f676615
Reviewed-on: https://go-review.googlesource.com/c/go/+/573517
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Emmanuel Odeke <emmanuel@orijtech.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Emmanuel Odeke <emmanuel@orijtech.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Diffstat (limited to 'src/net/http')
0 files changed, 0 insertions, 0 deletions