diff options
| author | Damien Neil <dneil@google.com> | 2024-01-05 16:10:33 -0800 |
|---|---|---|
| committer | Damien Neil <dneil@google.com> | 2024-02-29 19:48:56 +0000 |
| commit | 4e7bd20f8fdccdb2f0f30b051e3ea3fffb449367 (patch) | |
| tree | ce2ac02a231da90aed6007e0e209d64e9fa43b21 /src/net/http/server.go | |
| parent | adc575e64c8a49c0a14a8a6b0480c5f9815bdb1a (diff) | |
| download | go-4e7bd20f8fdccdb2f0f30b051e3ea3fffb449367.tar.xz | |
net/http: remove Content-Length header in http.Error
Error replies to a request with an error message and HTTP code.
Delete any preexisting Content-Length header before writing the header;
if a Content-Length is present, it's probably for content that the
caller has given up on writing.
For #50905
Change-Id: Ia3d4ca008be46fa5d41afadf29ca5cacb1c47660
Reviewed-on: https://go-review.googlesource.com/c/go/+/554216
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
Diffstat (limited to 'src/net/http/server.go')
| -rw-r--r-- | src/net/http/server.go | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/net/http/server.go b/src/net/http/server.go index 7d73cca43f..bd7cce6793 100644 --- a/src/net/http/server.go +++ b/src/net/http/server.go @@ -2173,6 +2173,7 @@ func (f HandlerFunc) ServeHTTP(w ResponseWriter, r *Request) { // writes are done to w. // The error message should be plain text. func Error(w ResponseWriter, error string, code int) { + w.Header().Del("Content-Length") w.Header().Set("Content-Type", "text/plain; charset=utf-8") w.Header().Set("X-Content-Type-Options", "nosniff") w.WriteHeader(code) |