aboutsummaryrefslogtreecommitdiff
path: root/src/net/http/server.go
diff options
context:
space:
mode:
authorKenny Grant <kennygrant@gmail.com>2015-09-27 14:53:18 +0100
committerBrad Fitzpatrick <bradfitz@golang.org>2015-10-05 17:31:36 +0000
commit4a6326e7b5f326e6079073fb843b4ab096cbf652 (patch)
treea944f3600989e25ca87ac543c1021ea1ed135b10 /src/net/http/server.go
parent9dd81d62275a963e3d9c37453fcde42ab929bd96 (diff)
downloadgo-4a6326e7b5f326e6079073fb843b4ab096cbf652.tar.xz
net/http: add response body to 413 and 400 errors
The existing serve() method returns a zero-length response body when it encounters an error, which results in a blank page and no visible error in browsers. This change sends a response body explaining the error for display in browsers. Fixes #12745 Change-Id: I9dc3b95ad88cb92c18ced51f6b52bd3b2c1b974c Reviewed-on: https://go-review.googlesource.com/15018 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Diffstat (limited to 'src/net/http/server.go')
-rw-r--r--src/net/http/server.go4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/net/http/server.go b/src/net/http/server.go
index f525815ac6..0bdc9b685c 100644
--- a/src/net/http/server.go
+++ b/src/net/http/server.go
@@ -1339,7 +1339,7 @@ func (c *conn) serve() {
// responding to them and hanging up
// while they're still writing their
// request. Undefined behavior.
- io.WriteString(c.rwc, "HTTP/1.1 413 Request Entity Too Large\r\n\r\n")
+ io.WriteString(c.rwc, "HTTP/1.1 413 Request Entity Too Large\r\nContent-Type: text/plain\r\nConnection: close\r\n\r\n413 Request Entity Too Large")
c.closeWriteAndWait()
break
} else if err == io.EOF {
@@ -1347,7 +1347,7 @@ func (c *conn) serve() {
} else if neterr, ok := err.(net.Error); ok && neterr.Timeout() {
break // Don't reply
}
- io.WriteString(c.rwc, "HTTP/1.1 400 Bad Request\r\n\r\n")
+ io.WriteString(c.rwc, "HTTP/1.1 400 Bad Request\r\nContent-Type: text/plain\r\nConnection: close\r\n\r\n400 Bad Request")
break
}