diff options
| author | Damien Neil <dneil@google.com> | 2024-07-26 13:23:09 -0700 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2024-07-29 21:29:55 +0000 |
| commit | 1ef6b2805ea1d78c082c7c55df39fc3d3942e4c9 (patch) | |
| tree | 8a3a74bfd21e961d9d1d0a04e771cba002c181a0 /src/net/http/server.go | |
| parent | ac51262592a20e16afec77163eff98be1d336f5c (diff) | |
| download | go-1ef6b2805ea1d78c082c7c55df39fc3d3942e4c9.tar.xz | |
net/http: don't write HEAD response body in ResponseWriter.ReadFrom
Responses to HEAD requests don't have a body.
The ResponseWriter automatically discards writes to the response body
when responding to a HEAD request. ResponseWriter.ReadFrom was failing
to discard writes under some circumstances; fix it to do so.
Fixes #68609
Change-Id: I912f6b2b2a535df28ae37b875fcf15b10da1af2b
Reviewed-on: https://go-review.googlesource.com/c/go/+/601475
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Auto-Submit: Damien Neil <dneil@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Diffstat (limited to 'src/net/http/server.go')
| -rw-r--r-- | src/net/http/server.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/net/http/server.go b/src/net/http/server.go index 1ff72a0455..1eb0e50206 100644 --- a/src/net/http/server.go +++ b/src/net/http/server.go @@ -611,7 +611,7 @@ func (w *response) ReadFrom(src io.Reader) (n int64, err error) { w.cw.flush() // make sure Header is written; flush data to rwc // Now that cw has been flushed, its chunking field is guaranteed initialized. - if !w.cw.chunking && w.bodyAllowed() { + if !w.cw.chunking && w.bodyAllowed() && w.req.Method != "HEAD" { n0, err := rf.ReadFrom(src) n += n0 w.written += n0 |