aboutsummaryrefslogtreecommitdiff
path: root/src/net/http/responsecontroller_test.go
diff options
context:
space:
mode:
authorNicholas S. Husin <nsh@golang.org>2026-03-30 19:17:03 -0400
committerNicholas Husin <nsh@golang.org>2026-04-10 14:18:34 -0700
commitccf4ba99a90f6f1366daef776ae90187c9f3c6b1 (patch)
tree379004141a9699a153e5555dc0721779513d74ef /src/net/http/responsecontroller_test.go
parent6299ca285a0a6bf7d2b1bfbb03b6c3288b846bdf (diff)
downloadgo-ccf4ba99a90f6f1366daef776ae90187c9f3c6b1.tar.xz
net/http: run tests for HTTP/3 where it can already pass
By default, our test harnesses (run and runSynctest) now use http3Mode, in addition to http1Mode and http2Mode, when no []testMode were explicitly defined for a given test. Tests that cannot currently pass for HTTP/3 have been modified to use http3SkippedMode, which serves as a convenient alias for the old default of []testMode{http1Mode, http2Mode}. We changed the default mode and defined http3SkippedMode so we have a clear list of TODOs in terms of how much changes are still needed before our HTTP/3 implementation reaches basic feature parity with HTTP/1 and HTTP/2. For #70914 Change-Id: I719d5d66399a51f7c3d96180ebed9b606a6a6964 Reviewed-on: https://go-review.googlesource.com/c/go/+/765320 Reviewed-by: Damien Neil <dneil@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Nicholas Husin <husin@google.com>
Diffstat (limited to 'src/net/http/responsecontroller_test.go')
-rw-r--r--src/net/http/responsecontroller_test.go14
1 files changed, 7 insertions, 7 deletions
diff --git a/src/net/http/responsecontroller_test.go b/src/net/http/responsecontroller_test.go
index a217891026..2c85589b91 100644
--- a/src/net/http/responsecontroller_test.go
+++ b/src/net/http/responsecontroller_test.go
@@ -48,7 +48,7 @@ func testResponseControllerFlush(t *testing.T, mode testMode) {
}
}
-func TestResponseControllerHijack(t *testing.T) { run(t, testResponseControllerHijack) }
+func TestResponseControllerHijack(t *testing.T) { run(t, testResponseControllerHijack, http3SkippedMode) }
func testResponseControllerHijack(t *testing.T, mode testMode) {
const header = "X-Header"
const value = "set"
@@ -78,7 +78,7 @@ func testResponseControllerHijack(t *testing.T, mode testMode) {
}
func TestResponseControllerSetPastWriteDeadline(t *testing.T) {
- run(t, testResponseControllerSetPastWriteDeadline)
+ run(t, testResponseControllerSetPastWriteDeadline, http3SkippedMode)
}
func testResponseControllerSetPastWriteDeadline(t *testing.T, mode testMode) {
cst := newClientServerTest(t, mode, HandlerFunc(func(w ResponseWriter, r *Request) {
@@ -120,7 +120,7 @@ func testResponseControllerSetPastWriteDeadline(t *testing.T, mode testMode) {
}
func TestResponseControllerSetFutureWriteDeadline(t *testing.T) {
- run(t, testResponseControllerSetFutureWriteDeadline)
+ run(t, testResponseControllerSetFutureWriteDeadline, http3SkippedMode)
}
func testResponseControllerSetFutureWriteDeadline(t *testing.T, mode testMode) {
errc := make(chan error, 1)
@@ -156,7 +156,7 @@ func testResponseControllerSetFutureWriteDeadline(t *testing.T, mode testMode) {
}
func TestResponseControllerSetPastReadDeadline(t *testing.T) {
- run(t, testResponseControllerSetPastReadDeadline)
+ run(t, testResponseControllerSetPastReadDeadline, http3SkippedMode)
}
func testResponseControllerSetPastReadDeadline(t *testing.T, mode testMode) {
readc := make(chan struct{})
@@ -220,7 +220,7 @@ func testResponseControllerSetPastReadDeadline(t *testing.T, mode testMode) {
}
func TestResponseControllerSetFutureReadDeadline(t *testing.T) {
- run(t, testResponseControllerSetFutureReadDeadline)
+ run(t, testResponseControllerSetFutureReadDeadline, http3SkippedMode)
}
func testResponseControllerSetFutureReadDeadline(t *testing.T, mode testMode) {
respBody := "response body"
@@ -256,7 +256,7 @@ func (w wrapWriter) Unwrap() ResponseWriter {
return w.ResponseWriter
}
-func TestWrappedResponseController(t *testing.T) { run(t, testWrappedResponseController) }
+func TestWrappedResponseController(t *testing.T) { run(t, testWrappedResponseController, http3SkippedMode) }
func testWrappedResponseController(t *testing.T, mode testMode) {
cst := newClientServerTest(t, mode, HandlerFunc(func(w ResponseWriter, r *Request) {
w = wrapWriter{w}
@@ -280,7 +280,7 @@ func testWrappedResponseController(t *testing.T, mode testMode) {
}
func TestResponseControllerEnableFullDuplex(t *testing.T) {
- run(t, testResponseControllerEnableFullDuplex)
+ run(t, testResponseControllerEnableFullDuplex, http3SkippedMode)
}
func testResponseControllerEnableFullDuplex(t *testing.T, mode testMode) {
cst := newClientServerTest(t, mode, HandlerFunc(func(w ResponseWriter, req *Request) {