diff options
| author | Brad Fitzpatrick <bradfitz@golang.org> | 2017-06-07 18:13:38 +0000 |
|---|---|---|
| committer | Brad Fitzpatrick <bradfitz@golang.org> | 2017-06-07 19:27:19 +0000 |
| commit | 7579f96676eb2ea932cfa02e805bbae02c0d310c (patch) | |
| tree | f1e54651170e82e4225b0cbbaa75dbe3f4621443 /src/net/http/request_test.go | |
| parent | 0aede73917c89d048211b3731fb19157acfe4431 (diff) | |
| download | go-7579f96676eb2ea932cfa02e805bbae02c0d310c.tar.xz | |
net/http: don't crash in Request.WithContext if Request.URL is nil
Fixes #20601
Change-Id: I296d50dc5210a735a2a65d64bfef05d14c93057b
Reviewed-on: https://go-review.googlesource.com/45073
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Rhys Hiltner <rhys@justin.tv>
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Diffstat (limited to 'src/net/http/request_test.go')
| -rw-r--r-- | src/net/http/request_test.go | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/src/net/http/request_test.go b/src/net/http/request_test.go index 1608d1c4fe..967156bac9 100644 --- a/src/net/http/request_test.go +++ b/src/net/http/request_test.go @@ -799,6 +799,13 @@ func TestWithContextDeepCopiesURL(t *testing.T) { if firstURL == secondURL { t.Errorf("unexpected change to original request's URL") } + + // And also check we don't crash on nil (Issue 20601) + req.URL = nil + reqCopy = req.WithContext(context.Background()) + if reqCopy.URL != nil { + t.Error("expected nil URL in cloned request") + } } // verify that NewRequest sets Request.GetBody and that it works |