diff options
| author | guoguangwu <guoguangwug@gmail.com> | 2024-07-15 01:31:15 +0000 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2024-08-14 18:15:48 +0000 |
| commit | 8b32ce586de9a4120bc7cdc104801113bed89f1d (patch) | |
| tree | 4e823d9cc766d58701053c6c8a61bc1769dee43a /src/net/http/httputil/reverseproxy_test.go | |
| parent | d3c82937e966537b5089db9dba4c7579e9b9c09a (diff) | |
| download | go-8b32ce586de9a4120bc7cdc104801113bed89f1d.tar.xz | |
net/http/httputil: close res body in test
Change-Id: Ic57c93a8d8413fe4985bc430255b6db90e11b70c
GitHub-Last-Rev: 25db6644c6cd3ae532796b18f8978f84a51376af
GitHub-Pull-Request: golang/go#68397
Reviewed-on: https://go-review.googlesource.com/c/go/+/597936
Reviewed-by: Damien Neil <dneil@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Damien Neil <dneil@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
Diffstat (limited to 'src/net/http/httputil/reverseproxy_test.go')
| -rw-r--r-- | src/net/http/httputil/reverseproxy_test.go | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/src/net/http/httputil/reverseproxy_test.go b/src/net/http/httputil/reverseproxy_test.go index 67d0e50593..2f9a5eec5c 100644 --- a/src/net/http/httputil/reverseproxy_test.go +++ b/src/net/http/httputil/reverseproxy_test.go @@ -137,6 +137,7 @@ func TestReverseProxy(t *testing.T) { if g, e := res.Trailer.Get("X-Unannounced-Trailer"), "unannounced_trailer_value"; g != e { t.Errorf("Trailer(X-Unannounced-Trailer) = %q ; want %q", g, e) } + res.Body.Close() // Test that a backend failing to be reached or one which doesn't return // a response results in a StatusBadGateway. @@ -328,6 +329,7 @@ func TestXForwardedFor(t *testing.T) { if err != nil { t.Fatalf("Get: %v", err) } + defer res.Body.Close() if g, e := res.StatusCode, backendStatus; g != e { t.Errorf("got res.StatusCode %d; expected %d", g, e) } @@ -801,6 +803,7 @@ func TestReverseProxy_Post(t *testing.T) { if err != nil { t.Fatalf("Do: %v", err) } + defer res.Body.Close() if g, e := res.StatusCode, backendStatus; g != e { t.Errorf("got res.StatusCode %d; expected %d", g, e) } @@ -1571,7 +1574,7 @@ func TestUnannouncedTrailer(t *testing.T) { } io.ReadAll(res.Body) - + res.Body.Close() if g, w := res.Trailer.Get("X-Unannounced-Trailer"), "unannounced_trailer_value"; g != w { t.Errorf("Trailer(X-Unannounced-Trailer) = %q; want %q", g, w) } |