diff options
| author | Damien Neil <dneil@google.com> | 2025-03-19 09:26:31 -0700 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2025-03-19 09:57:03 -0700 |
| commit | 1aa9c31ffc8af3fd33bfa995ecf55f08daf33f81 (patch) | |
| tree | db6da85a2ac2271c0642040f77b7debc198cf406 /src/net/http/httputil/reverseproxy.go | |
| parent | deb6790fcfe943c640a4ef393036690eef5eef5c (diff) | |
| download | go-1aa9c31ffc8af3fd33bfa995ecf55f08daf33f81.tar.xz | |
net/http/httputil: don't call WriteHeader after Hijack
CL 637939 changed ReverseProxy to report errors encountered when
copying data on an hijacked connection. This is generally not useful,
and when using the default error handler results in WriteHeader
being called on a hijacked connection.
While this is harmless with standard net/http ResponseWriter
implementations, it can confuse middleware layers.
Fixes #72954
Change-Id: I21f3d3d515e114dc5c298d7dbc3796c505d3c82f
Reviewed-on: https://go-review.googlesource.com/c/go/+/659255
Reviewed-by: Jonathan Amsterdam <jba@google.com>
Auto-Submit: Damien Neil <dneil@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Diffstat (limited to 'src/net/http/httputil/reverseproxy.go')
| -rw-r--r-- | src/net/http/httputil/reverseproxy.go | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/src/net/http/httputil/reverseproxy.go b/src/net/http/httputil/reverseproxy.go index 5d27880735..8d3e20c302 100644 --- a/src/net/http/httputil/reverseproxy.go +++ b/src/net/http/httputil/reverseproxy.go @@ -802,9 +802,6 @@ func (p *ReverseProxy) handleUpgradeResponse(rw http.ResponseWriter, req *http.R if err == nil { err = <-errc } - if err != nil && err != errCopyDone { - p.getErrorHandler()(rw, req, fmt.Errorf("can't copy: %v", err)) - } } var errCopyDone = errors.New("hijacked connection copy complete") |