diff options
| author | Nicholas S. Husin <nsh@golang.org> | 2026-04-13 20:58:19 -0400 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2026-04-13 18:39:04 -0700 |
| commit | f35e6df70bf3cbb748657a58f9b5bb9a9a491b69 (patch) | |
| tree | 0e29b08c582c43742157b9e62d4f017ea9fdea3f /src/net/http/clientserver_test.go | |
| parent | 524bd85dfd9c2c9fac263a2806e17cedb3cea85c (diff) | |
| download | go-f35e6df70bf3cbb748657a58f9b5bb9a9a491b69.tar.xz | |
net/http: temporarily disable HTTP/3 tests
Tests for HTTP/3 are unfortunately still flaky. The flakes seem to come
mostly from two sources:
1. QUIC connections are not shutdown fast enough, causing them to be
detected as goroutine leaks.
2. x/net/quic has a race condition where its output buffer are written
to without locks (synchronously and intentionally, for optimization),
but may be asynchronously written when the QUIC stream receives a
STOP_SENDING frame.
Therefore, skip http3Mode for now until the above flakes are fixed.
For #70914
Fixes #78701
Change-Id: If0c857c0933b977fb10a4481124680726a6a6964
Reviewed-on: https://go-review.googlesource.com/c/go/+/766740
Reviewed-by: Nicholas Husin <husin@google.com>
Auto-Submit: Nicholas Husin <husin@google.com>
LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Diffstat (limited to 'src/net/http/clientserver_test.go')
| -rw-r--r-- | src/net/http/clientserver_test.go | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/src/net/http/clientserver_test.go b/src/net/http/clientserver_test.go index 0bcc950103..a1258089c7 100644 --- a/src/net/http/clientserver_test.go +++ b/src/net/http/clientserver_test.go @@ -112,6 +112,12 @@ func run[T TBRun[T]](t T, f func(t T, mode testMode), opts ...any) { setParallel(t) } for _, mode := range modes { + // HTTP/3 tests are unfortunately still flakier than we would like. + // Disable them for now. + // TODO(nsh): re-enable the tests once they are no longer flaky. + if mode == http3Mode { + continue + } t.Run(string(mode), func(t T) { t.Helper() if t, ok := any(t).(*testing.T); ok && parallel { |