diff options
| author | Caleb Spare <cespare@gmail.com> | 2015-10-20 00:35:42 -0700 |
|---|---|---|
| committer | Brad Fitzpatrick <bradfitz@golang.org> | 2015-11-17 04:06:32 +0000 |
| commit | babdb3832072b6ca55e2dfe071bac25d865f8911 (patch) | |
| tree | 0fadcc48b7f2385eba22c9e530422f97acb173f5 /src/net/http/client_test.go | |
| parent | 662ab8be31d30e250716cc1abd63d6be68563543 (diff) | |
| download | go-babdb3832072b6ca55e2dfe071bac25d865f8911.tar.xz | |
net/http: detect when an HTTPS client contacts an HTTP server
Inspect the crypto/tls error to recognize this case and give a more
helpful error.
Fixes #11111.
Change-Id: I63f6af8c375aa892326ccccbd29655d54d68df0b
Reviewed-on: https://go-review.googlesource.com/16079
Run-TryBot: Caleb Spare <cespare@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Diffstat (limited to 'src/net/http/client_test.go')
| -rw-r--r-- | src/net/http/client_test.go | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/src/net/http/client_test.go b/src/net/http/client_test.go index 01f8cbaa2d..40d5109862 100644 --- a/src/net/http/client_test.go +++ b/src/net/http/client_test.go @@ -743,6 +743,20 @@ func TestResponseSetsTLSConnectionState(t *testing.T) { } } +// Check that an HTTPS client can interpret a particular TLS error +// to determine that the server is speaking HTTP. +// See golang.org/issue/11111. +func TestHTTPSClientDetectsHTTPServer(t *testing.T) { + defer afterTest(t) + ts := httptest.NewServer(HandlerFunc(func(w ResponseWriter, r *Request) {})) + defer ts.Close() + + _, err := Get(strings.Replace(ts.URL, "http", "https", 1)) + if got := err.Error(); !strings.Contains(got, "HTTP response to HTTPS client") { + t.Fatalf("error = %q; want error indicating HTTP response to HTTPS request", got) + } +} + // Verify Response.ContentLength is populated. https://golang.org/issue/4126 func TestClientHeadContentLength(t *testing.T) { defer afterTest(t) |