diff options
| author | isharipo <iskander.sharipov@intel.com> | 2018-04-03 22:33:03 +0300 |
|---|---|---|
| committer | Brad Fitzpatrick <bradfitz@golang.org> | 2018-04-03 19:55:04 +0000 |
| commit | 02952ad7a84846524a15f4e2b0db8083f74ce836 (patch) | |
| tree | 6e05eb56ae2b3b2f6a509cc39a6d11ca8cb36fc4 /src/math | |
| parent | 00c8e149b67da589f82b7a19df9735e4f03ec5ae (diff) | |
| download | go-02952ad7a84846524a15f4e2b0db8083f74ce836.tar.xz | |
math/big: remove "else" from if with block that ends with return
That "else" was needed due to gc DCE limitations.
Now it's not the case and we can avoid go lint complaints.
(See #23521 and https://golang.org/cl/91056.)
There is inlining test for bigEndianWord, so if test
is passing, no performance regression should occur.
Change-Id: Id84d63f361e5e51a52293904ff042966c83c16e9
Reviewed-on: https://go-review.googlesource.com/104555
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Diffstat (limited to 'src/math')
| -rw-r--r-- | src/math/big/nat.go | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/math/big/nat.go b/src/math/big/nat.go index 1f259410c4..1208ea76c8 100644 --- a/src/math/big/nat.go +++ b/src/math/big/nat.go @@ -1245,9 +1245,8 @@ func (z nat) bytes(buf []byte) (i int) { func bigEndianWord(buf []byte) Word { if _W == 64 { return Word(binary.BigEndian.Uint64(buf)) - } else { // Explicit else is required to get inlining. See #23521 - return Word(binary.BigEndian.Uint32(buf)) } + return Word(binary.BigEndian.Uint32(buf)) } // setBytes interprets buf as the bytes of a big-endian unsigned |