diff options
| author | Russ Cox <rsc@golang.org> | 2014-07-16 19:26:36 -0400 |
|---|---|---|
| committer | Russ Cox <rsc@golang.org> | 2014-07-16 19:26:36 -0400 |
| commit | 055dfc204c7b2c8eae1603b09fe71deb73f0e627 (patch) | |
| tree | f59ff556adc620844c3cf5f13c08ace2cf803a98 /src/liblink | |
| parent | 0c6b55e76ba6d59f57c81ca1160d833c79270753 (diff) | |
| download | go-055dfc204c7b2c8eae1603b09fe71deb73f0e627.tar.xz | |
liblink: fix precedence bug in pcdata comparison
As written, the ! applies before the &1.
This would crash writing out missing pcdata tables
if we ever used non-contiguous IDs in a function.
We don't, but fix anyway.
LGTM=iant, minux
R=minux, iant
CC=golang-codereviews
https://golang.org/cl/117810047
Diffstat (limited to 'src/liblink')
| -rw-r--r-- | src/liblink/pcln.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/liblink/pcln.c b/src/liblink/pcln.c index 4b2b85543e..f0ee1dc672 100644 --- a/src/liblink/pcln.c +++ b/src/liblink/pcln.c @@ -279,7 +279,7 @@ linkpcln(Link *ctxt, LSym *cursym) } // pcdata. for(i=0; i<npcdata; i++) { - if(!(havepc[i/32]>>(i%32))&1) + if(((havepc[i/32]>>(i%32))&1) == 0) continue; funcpctab(ctxt, &pcln->pcdata[i], cursym, "pctopcdata", pctopcdata, (void*)(uintptr)i); } |