diff options
| author | Hana Kim <hyangah@gmail.com> | 2016-06-15 12:53:05 -0400 |
|---|---|---|
| committer | Hyang-Ah Hana Kim <hyangah@gmail.com> | 2016-06-16 16:22:03 +0000 |
| commit | c3818e56d0f60493a63b2bb03a09f261d3e0ada2 (patch) | |
| tree | aa7d13e6c9b04ad44f43a211fd146490cb67f8e9 /src/internal/trace/parser_test.go | |
| parent | ea2ac3fe5fb2011b077809e60bc018e0c6caa66c (diff) | |
| download | go-c3818e56d0f60493a63b2bb03a09f261d3e0ada2.tar.xz | |
internal/trace: err if binary is not supplied for old trace
Change-Id: Id25c90993c4cbb7449d7031301b6d214a67d7633
Reviewed-on: https://go-review.googlesource.com/24134
Reviewed-by: Dmitry Vyukov <dvyukov@google.com>
Run-TryBot: Dmitry Vyukov <dvyukov@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Diffstat (limited to 'src/internal/trace/parser_test.go')
| -rw-r--r-- | src/internal/trace/parser_test.go | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/internal/trace/parser_test.go b/src/internal/trace/parser_test.go index 340f106484..daad3e3ad7 100644 --- a/src/internal/trace/parser_test.go +++ b/src/internal/trace/parser_test.go @@ -42,7 +42,9 @@ func TestParseCanned(t *testing.T) { if err != nil { t.Fatalf("failed to read input file: %v", err) } - _, err = Parse(bytes.NewReader(data), "") + // Instead of Parse that requires a proper binary name for old traces, + // we use 'parse' that omits symbol lookup if an empty string is given. + _, _, err = parse(bytes.NewReader(data), "") switch { case strings.HasSuffix(f.Name(), "_good"): if err != nil { |