diff options
| author | Dmitry Vyukov <dvyukov@google.com> | 2016-08-08 15:41:18 +0200 |
|---|---|---|
| committer | Dmitry Vyukov <dvyukov@google.com> | 2016-08-19 19:22:17 +0000 |
| commit | a50f9859bd15784d047875624c9fa91ce69bd85b (patch) | |
| tree | 4d3669440dab1713f41aef01f404bfa7372304eb /src/internal/trace/parser.go | |
| parent | 93372673ce51b9462d7ae0f87ac28ffe0c2ad37d (diff) | |
| download | go-a50f9859bd15784d047875624c9fa91ce69bd85b.tar.xz | |
internal/trace: fix analysis of EvGoWaiting/EvGoInSyscall events
When tracing is started in the middle of program execution,
we already have a number of runnable goroutines and a number
of blocked/in syscall goroutines. In order to reflect these
goroutines in the trace, we emit EvGoCreate for all existing
goroutines. Then for blocked/in syscall goroutines we additionally
emit EvGoWaiting/EvGoInSyscall events. These events don't reset g.ev
during trace analysis. So next EvGoStart finds g.ev set to the
previous EvGoCreate. As the result time between EvGoCreate and
EvGoStart is accounted as scheduler latency. While in reality
it is blocking/syscall time.
Properly reset g.ev for EvGoWaiting/EvGoInSyscall events.
Change-Id: I0615ba31ed7567600a0667ebb27458481da73adb
Reviewed-on: https://go-review.googlesource.com/25572
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Diffstat (limited to 'src/internal/trace/parser.go')
| -rw-r--r-- | src/internal/trace/parser.go | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/internal/trace/parser.go b/src/internal/trace/parser.go index c31517f683..b1fc17ac58 100644 --- a/src/internal/trace/parser.go +++ b/src/internal/trace/parser.go @@ -581,11 +581,13 @@ func postProcessTrace(ver int, events []*Event) error { return fmt.Errorf("g %v is not runnable before EvGoWaiting (offset %v, time %v)", ev.G, ev.Off, ev.Ts) } g.state = gWaiting + g.ev = ev case EvGoInSyscall: if g.state != gRunnable { return fmt.Errorf("g %v is not runnable before EvGoInSyscall (offset %v, time %v)", ev.G, ev.Off, ev.Ts) } g.state = gWaiting + g.ev = ev case EvGoCreate: if err := checkRunning(p, g, ev, true); err != nil { return err |