diff options
| author | Tim King <taking@google.com> | 2024-08-26 15:49:09 -0700 |
|---|---|---|
| committer | Tim King <taking@google.com> | 2024-08-28 21:03:29 +0000 |
| commit | 9e8ea567c838574a0f14538c0bbbd83c3215aa55 (patch) | |
| tree | fc7865088176fffae13b4c9a900cf565622d7ea6 /src/internal/pkgbits/decoder.go | |
| parent | 6d52d7d22b70a5faa2868b6406ccdc7fd9b89083 (diff) | |
| download | go-9e8ea567c838574a0f14538c0bbbd83c3215aa55.tar.xz | |
cmd/compile/internal/noder: write V2 bitstream aliastypeparams=1
Enables V2 unified IR bitstreams when GOEXPERIMENT aliastypeparams
are enabled.
Allows pkgbits.NewPkgEncoder to set the output version.
Reenables support for writing V0 streams.
Updates #68778
Updates #68526
Change-Id: I590c494d81ab7db148232ceaba52229068d1e986
Reviewed-on: https://go-review.googlesource.com/c/go/+/608595
Reviewed-by: David Chase <drchase@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Diffstat (limited to 'src/internal/pkgbits/decoder.go')
| -rw-r--r-- | src/internal/pkgbits/decoder.go | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/src/internal/pkgbits/decoder.go b/src/internal/pkgbits/decoder.go index ca66446dba..09f26a84bd 100644 --- a/src/internal/pkgbits/decoder.go +++ b/src/internal/pkgbits/decoder.go @@ -82,8 +82,8 @@ func NewPkgDecoder(pkgPath, input string) PkgDecoder { assert(binary.Read(r, binary.LittleEndian, &ver) == nil) pr.version = Version(ver) - if pr.version >= V2 { // TODO(taking): Switch to numVersions. - panic(fmt.Errorf("cannot decode %q, export data version %d is too new", pkgPath, pr.version)) + if pr.version >= numVersions { + panic(fmt.Errorf("cannot decode %q, export data version %d is greater than maximum supported version %d", pkgPath, pr.version, numVersions-1)) } if pr.version.Has(Flags) { @@ -101,7 +101,9 @@ func NewPkgDecoder(pkgPath, input string) PkgDecoder { assert(err == nil) pr.elemData = input[pos:] - assert(len(pr.elemData)-8 == int(pr.elemEnds[len(pr.elemEnds)-1])) + + const fingerprintSize = 8 + assert(len(pr.elemData)-fingerprintSize == int(pr.elemEnds[len(pr.elemEnds)-1])) return pr } |