diff options
| author | Michael Pratt <mpratt@google.com> | 2025-05-05 13:44:26 -0400 |
|---|---|---|
| committer | Michael Pratt <mpratt@google.com> | 2025-05-21 10:21:55 -0700 |
| commit | e6dacf91ffb0a356aa692ab5c46411e2eef913f3 (patch) | |
| tree | fc337b1d3fe594503468a6af639ed6459442ee2a /src/internal/coverage | |
| parent | f12c66fbed546645389cf184b0e2ffd6ad9f78ec (diff) | |
| download | go-e6dacf91ffb0a356aa692ab5c46411e2eef913f3.tar.xz | |
runtime: use cgroup CPU limit to set GOMAXPROCS
This CL adds two related features enabled by default via compatibility
GODEBUGs containermaxprocs and updatemaxprocs.
On Linux, containermaxprocs makes the Go runtime consider cgroup CPU
bandwidth limits (quota/period) when setting GOMAXPROCS. If the cgroup
limit is lower than the number of logical CPUs available, then the
cgroup limit takes precedence.
On all OSes, updatemaxprocs makes the Go runtime periodically
recalculate the default GOMAXPROCS value and update GOMAXPROCS if it has
changed. If GOMAXPROCS is set manually, this update does not occur. This
is intended primarily to detect changes to cgroup limits, but it applies
on all OSes because the CPU affinity mask can change as well.
The runtime only considers the limit in the leaf cgroup (the one that
actually contains the process), caching the CPU limit file
descriptor(s), which are periodically reread for updates. This is a
small departure from the original proposed design. It will not consider
limits of parent cgroups (which may be lower than the leaf), and it will
not detection cgroup migration after process start.
We can consider changing this in the future, but the simpler approach is
less invasive; less risk to packages that have some awareness of runtime
internals. e.g., if the runtime periodically opens new files during
execution, file descriptor leak detection is difficult to implement in a
stable way.
For #73193.
Cq-Include-Trybots: luci.golang.try:gotip-linux-amd64-longtest
Change-Id: I6a6a636c631c1ae577fb8254960377ba91c5dc98
Reviewed-on: https://go-review.googlesource.com/c/go/+/670497
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Diffstat (limited to 'src/internal/coverage')
| -rw-r--r-- | src/internal/coverage/pkid.go | 23 |
1 files changed, 17 insertions, 6 deletions
diff --git a/src/internal/coverage/pkid.go b/src/internal/coverage/pkid.go index f68523a348..30b5ad49ac 100644 --- a/src/internal/coverage/pkid.go +++ b/src/internal/coverage/pkid.go @@ -45,18 +45,29 @@ package coverage // as opposed to a fixed list. var rtPkgs = [...]string{ + "internal/asan", + "internal/byteorder", + "internal/coverage/rtcov", "internal/cpu", + "internal/bytealg", "internal/goarch", - "internal/runtime/atomic", - "internal/goos", + "internal/abi", "internal/chacha8rand", + "internal/godebugs", + "internal/goexperiment", + "internal/goos", + "internal/msan", + "internal/profilerecord", + "internal/race", + "internal/runtime/atomic", + "internal/runtime/exithook", + "internal/runtime/gc", + "internal/runtime/math", + "internal/runtime/strconv", "internal/runtime/sys", - "internal/abi", "internal/runtime/maps", - "internal/runtime/math", - "internal/bytealg", - "internal/goexperiment", "internal/runtime/syscall", + "internal/runtime/cgroup", "internal/stringslite", "runtime", } |