diff options
| author | Bryan C. Mills <bcmills@google.com> | 2022-04-22 21:19:10 -0400 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2022-09-26 17:26:59 +0000 |
| commit | bd8a5b00fcf71fb711ba8996a880b5b07f7b3634 (patch) | |
| tree | cad512abd760b40affd7a7dc934ca0e659c74568 /src/internal/coverage/stringtab | |
| parent | b8d4a14a660827ea0331eb6cad99860bf5fdf66f (diff) | |
| download | go-bd8a5b00fcf71fb711ba8996a880b5b07f7b3634.tar.xz | |
os/exec: split parent I/O pipes by whether they are pumped by user code or internal goroutines
The pipes pumped by goroutines can be closed as soon as their
respective goroutines are done.
The pipes pumped by user code, however, are documented to be closed in
Wait. When we add the WaitDelay field, it isn't obvious that we should
terminate the user-pumped pipes when the WaitDelay expires, since Wait
itself isn't going to wait for those user-controlled goroutines to
complete.
(It's a bit more complicated than that because the documentation
currently states that Wait must not be called while the pipes are
being read — but it isn't obvious to me that that advice is entirely
correct.)
For #50436.
Change-Id: I97909c91d2097fb75138a360747168c08609696d
Reviewed-on: https://go-review.googlesource.com/c/go/+/401894
Reviewed-by: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
Diffstat (limited to 'src/internal/coverage/stringtab')
0 files changed, 0 insertions, 0 deletions