diff options
| author | Rob Pike <r@golang.org> | 2014-10-01 21:35:12 +0000 |
|---|---|---|
| committer | Rob Pike <r@golang.org> | 2014-10-01 21:35:12 +0000 |
| commit | 9f4084278fd0038ef4deedab78ee4d7d2bc1a636 (patch) | |
| tree | 017bd278cdd880ae4bc5125d6b60216ce1fc7f73 /src/fmt | |
| parent | 62d3202aaa0fb131be1f0dbf21e97dbe11b177dc (diff) | |
| download | go-9f4084278fd0038ef4deedab78ee4d7d2bc1a636.tar.xz | |
fmt: fix internal unknownType function
This thing should never be called, but before
151960044 it was being called, incorrectly.
This is now just a precaution but let's pretend it
Fixes #8843
even though that was fixed by 151960044.
The test case was already there and ran, another mystery.
LGTM=rsc
R=rsc
CC=golang-codereviews
https://golang.org/cl/151970043
Diffstat (limited to 'src/fmt')
| -rw-r--r-- | src/fmt/print.go | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/fmt/print.go b/src/fmt/print.go index 679c577dbd..de69e90fb7 100644 --- a/src/fmt/print.go +++ b/src/fmt/print.go @@ -297,13 +297,13 @@ func parsenum(s string, start, end int) (num int, isnum bool, newi int) { return } -func (p *pp) unknownType(v interface{}) { - if v == nil { +func (p *pp) unknownType(v reflect.Value) { + if !v.IsValid() { p.buf.Write(nilAngleBytes) return } p.buf.WriteByte('?') - p.buf.WriteString(reflect.TypeOf(v).String()) + p.buf.WriteString(v.Type().String()) p.buf.WriteByte('?') } |
