diff options
| author | Zamicol <zamicol@gmail.com> | 2022-10-14 03:10:28 +0000 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2022-10-17 14:50:31 +0000 |
| commit | 9abcc487f8b04db8fd46eaa429a7eef5a5228241 (patch) | |
| tree | fe736d3a6d1b87691fd5345f42ba4ae6205ebc8c /src/flag | |
| parent | 3d92205ef5ed42147376d929e0f59c765974e345 (diff) | |
| download | go-9abcc487f8b04db8fd46eaa429a7eef5a5228241.tar.xz | |
flag: remove "// BUG" comment
Remove a vestigial " // BUG" comment as there is no bug in the relevant code section and comment predated other changes. Also removed a needless allocation and conformed to the "v, ok := a[x]" standard convention. Tests are passing.
Change-Id: Id28ad1baf77447052b54b341f018e573bac0c11a
GitHub-Last-Rev: 26084698bfc0972d7e0fec0de4f31cc87e3a5f7a
GitHub-Pull-Request: golang/go#56210
Reviewed-on: https://go-review.googlesource.com/c/go/+/442815
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: David Chase <drchase@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Run-TryBot: Ian Lance Taylor <iant@google.com>
Reviewed-by: Rob Pike <r@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Diffstat (limited to 'src/flag')
| -rw-r--r-- | src/flag/flag.go | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/flag/flag.go b/src/flag/flag.go index f6b38908f6..ef3cf29c0c 100644 --- a/src/flag/flag.go +++ b/src/flag/flag.go @@ -1056,9 +1056,9 @@ func (f *FlagSet) parseOne() (bool, error) { break } } - m := f.formal - flag, alreadythere := m[name] // BUG - if !alreadythere { + + flag, ok := f.formal[name] + if !ok { if name == "help" || name == "h" { // special case for nice help message. f.usage() return false, ErrHelp |