diff options
| author | Josh Bleecher Snyder <josharian@gmail.com> | 2015-05-13 19:27:59 -0700 |
|---|---|---|
| committer | Josh Bleecher Snyder <josharian@gmail.com> | 2015-05-14 02:32:28 +0000 |
| commit | dbf533a5460d7fcc7d7be77014fd74a8aff8c412 (patch) | |
| tree | 35f0cf71e5730df8e77e4ed70bc5a2937e0497a9 /src/encoding | |
| parent | ef54930ebb65f1d611cb321eb86062fd4accc0ff (diff) | |
| download | go-dbf533a5460d7fcc7d7be77014fd74a8aff8c412.tar.xz | |
encoding/json: make BenchmarkSkipValue more stable
BenchmarkSkipValue was sensitive to the value of
b.N due to its significant startup cost.
Two adjacent runs before this CL:
BenchmarkSkipValue 50 21047499 ns/op 93.37 MB/s
BenchmarkSkipValue 100 17260554 ns/op 118.05 MB/s
After this CL, using benchtime to recreate the
difference in b.N:
BenchmarkSkipValue 50 15204797 ns/op 131.67 MB/s
BenchmarkSkipValue 100 15332319 ns/op 130.58 MB/s
Change-Id: Iac86f86dd774d535302fa5e4c08f89f8da00be9e
Reviewed-on: https://go-review.googlesource.com/10053
Reviewed-by: Andrew Gerrand <adg@golang.org>
Diffstat (limited to 'src/encoding')
| -rw-r--r-- | src/encoding/json/scanner_test.go | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/encoding/json/scanner_test.go b/src/encoding/json/scanner_test.go index 7880342902..66383ef0ef 100644 --- a/src/encoding/json/scanner_test.go +++ b/src/encoding/json/scanner_test.go @@ -209,6 +209,7 @@ var benchScan scanner func BenchmarkSkipValue(b *testing.B) { initBig() + b.ResetTimer() for i := 0; i < b.N; i++ { nextValue(jsonBig, &benchScan) } |