diff options
| author | Changkun Ou <hi@changkun.us> | 2020-09-14 10:24:59 +0200 |
|---|---|---|
| committer | Ian Lance Taylor <iant@golang.org> | 2020-09-14 20:27:49 +0000 |
| commit | a408139bb0166f6e0a5d9fd17fc934da960c354e (patch) | |
| tree | f5cade5946cab5b71a931a344a4a56143695b57d /src/encoding | |
| parent | 57646534297a9bd193e6aaa4239c98984f371b97 (diff) | |
| download | go-a408139bb0166f6e0a5d9fd17fc934da960c354e.tar.xz | |
testing: fix panicking tests hang if Cleanup calls FailNow
Previously, it was impossible to call FailNow in a Cleanup.
Because it can terminate a panicking goroutine and cause its
parent hangs on t.signal channel. This CL sends the signal
in a deferred call to prevent the hang.
Fixes #41355
Change-Id: I4552d3a7ea763ef86817bf9b50c0e37fb34bf20f
Reviewed-on: https://go-review.googlesource.com/c/go/+/254637
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Emmanuel Odeke <emm.odeke@gmail.com>
Diffstat (limited to 'src/encoding')
0 files changed, 0 insertions, 0 deletions