diff options
| author | Leigh McCulloch <leighmcc@gmail.com> | 2017-11-03 05:48:43 +0000 |
|---|---|---|
| committer | Brad Fitzpatrick <bradfitz@golang.org> | 2017-11-04 04:13:41 +0000 |
| commit | 8db19a496640db4c7c318007c82eaa5d65c85b93 (patch) | |
| tree | ddae5894fcfb0ca011825da4a7076869110a0b23 /src/encoding | |
| parent | 0ee4527ac7a4472c51c13948a3ac3e0c51a51838 (diff) | |
| download | go-8db19a496640db4c7c318007c82eaa5d65c85b93.tar.xz | |
all: change github.com issue links to golang.org
The go repository contains a mix of github.com/golang/go/issues/xxxxx
and golang.org/issues/xxxxx URLs for references to issues in the issue
tracker. We should use one for consistency, and golang.org is preferred
in case the project moves the issue tracker in the future.
This reasoning is taken from a comment Sam Whited left on a CL I
recently opened: https://go-review.googlesource.com/c/go/+/73890.
In that CL I referenced an issue using its github.com URL, because other
tests in the file I was changing contained references to issues using
their github.com URL. Sam Whited left a comment on the CL stating I
should change it to the golang.org URL.
If new code is intended to reference issues via golang.org and not
github.com, existing code should be updated so that precedence exists
for contributors who are looking at the existing code as a guide for the
code they should write.
Change-Id: I3b9053fe38a1c56fc101a8b7fd7b8f310ba29724
Reviewed-on: https://go-review.googlesource.com/75673
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Diffstat (limited to 'src/encoding')
| -rw-r--r-- | src/encoding/json/encode_test.go | 2 | ||||
| -rw-r--r-- | src/encoding/xml/read_test.go | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/encoding/json/encode_test.go b/src/encoding/json/encode_test.go index 3fda6a0c71..db89d113da 100644 --- a/src/encoding/json/encode_test.go +++ b/src/encoding/json/encode_test.go @@ -943,7 +943,7 @@ func TestMarshalRawMessageValue(t *testing.T) { // // The tests below marked with Issue6458 used to generate "ImZvbyI=" instead "foo". // This behavior was intentionally changed in Go 1.8. - // See https://github.com/golang/go/issues/14493#issuecomment-255857318 + // See https://golang.org/issues/14493#issuecomment-255857318 {rawText, `"foo"`, true}, // Issue6458 {&rawText, `"foo"`, true}, {[]interface{}{rawText}, `["foo"]`, true}, // Issue6458 diff --git a/src/encoding/xml/read_test.go b/src/encoding/xml/read_test.go index ba203cd98b..8c2e70fa22 100644 --- a/src/encoding/xml/read_test.go +++ b/src/encoding/xml/read_test.go @@ -819,7 +819,7 @@ const ( ` ) -// github.com/golang/go/issues/13417 +// golang.org/issues/13417 func TestUnmarshalEmptyValues(t *testing.T) { // Test first with a zero-valued dst. v := new(Parent) |