aboutsummaryrefslogtreecommitdiff
path: root/src/encoding
diff options
context:
space:
mode:
authorChris O'Hara <cohara87@gmail.com>2023-08-16 11:14:53 +1000
committerJohan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>2023-08-18 17:06:41 +0000
commit795e779610cd1ef8ad4c137c067a23ace1190115 (patch)
treec115b825f160b579133d8ac6af5ccbb2051cd89b /src/encoding
parente8a767b609a32972aca848b806700b3f7ddd34d3 (diff)
downloadgo-795e779610cd1ef8ad4c137c067a23ace1190115.tar.xz
runtime/internal/wasitest: skip racy TCP echo test
The wasip1 TCP echo test introduced in CL 493358 has a race condition with port selection. The test runner probes for a free port and then asks the WASM runtime to listen on the port, which may be taken by another process in the interim. Due to limitations with WASI preview 1, the guest is unable to query the port it's listening on. The test cannot ask the WASM runtime to listen on port 0 (choose a free port) since there's currently no way for the test to query the selected port and connect to it. Given the race condition is unavoidable, this test is now disabled by default and requires opt-in via an environment variable. This commit also eliminates the hard-coded connection timeout. Fixes #61820. Change-Id: I375145c1a1d03ad45c44f528da3347397e6dcb01 Reviewed-on: https://go-review.googlesource.com/c/go/+/519895 Run-TryBot: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com> Reviewed-by: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Bryan Mills <bcmills@google.com>
Diffstat (limited to 'src/encoding')
0 files changed, 0 insertions, 0 deletions