diff options
| author | Bryan C. Mills <bcmills@google.com> | 2024-03-06 17:50:45 -0500 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2024-03-11 22:10:38 +0000 |
| commit | 2ab9218c86ed625362df5060f64fcd59398a76f3 (patch) | |
| tree | 68fe684362654b203b33020007533176363ca2cc /src/encoding | |
| parent | a18aa0e3d14271659398648a49e54683ded4456c (diff) | |
| download | go-2ab9218c86ed625362df5060f64fcd59398a76f3.tar.xz | |
cmd/go/internal/modfetch: pass "-c" arguments to git before subcommands
I accidentally transposed the arguments in CL 556358, causing the
shallow 'git fetch' attempt to always fail. That didn't break any
tests because we fall back to a full fetch, which works for nearly all
real Git servers, and we didn't have a test that checked for shallow
fetches.
Tested manually using:
GOPROXY=direct go mod download -x -json gerrit.wikimedia.org/r/mediawiki@v0.0.0-20240202145822-67da0cbcfdf7
(I'm still thinking about how to add a proper regression test.)
Fixes #66147.
Change-Id: I0bb17283bae856f369fd24f29375e507d0999933
Cq-Include-Trybots: luci.golang.try:gotip-darwin-amd64-longtest,gotip-linux-amd64-longtest,gotip-windows-amd64-longtest
Reviewed-on: https://go-review.googlesource.com/c/go/+/569422
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Michael Matloob <matloob@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Diffstat (limited to 'src/encoding')
0 files changed, 0 insertions, 0 deletions