diff options
| author | Keith Randall <khr@golang.org> | 2021-09-11 06:50:06 -0700 |
|---|---|---|
| committer | Keith Randall <khr@golang.org> | 2021-09-21 17:25:35 +0000 |
| commit | fa5c5043bca5264fabbdc47d780cfb53b1f5d9a3 (patch) | |
| tree | 358306b30977f6619dac95622e626e33983004e6 /src/encoding/xml | |
| parent | 13aa0d8f578e9c293970fe462f79655899959093 (diff) | |
| download | go-fa5c5043bca5264fabbdc47d780cfb53b1f5d9a3.tar.xz | |
encoding/xml: truncate generic type names
xml names can't have any of '[],' in them, which might appear in
generic type names. Truncate at the first '[' so the names are still valid.
Fixes #48318
Change-Id: I110ff4269f763089467e7cf84b0f0c5075fb44b7
Reviewed-on: https://go-review.googlesource.com/c/go/+/349349
Trust: Keith Randall <khr@golang.org>
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
Diffstat (limited to 'src/encoding/xml')
| -rw-r--r-- | src/encoding/xml/marshal.go | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/encoding/xml/marshal.go b/src/encoding/xml/marshal.go index d8a04a95a2..a8c8f659ca 100644 --- a/src/encoding/xml/marshal.go +++ b/src/encoding/xml/marshal.go @@ -494,6 +494,10 @@ func (p *printer) marshalValue(val reflect.Value, finfo *fieldInfo, startTemplat } if start.Name.Local == "" { name := typ.Name() + if i := strings.IndexByte(name, '['); i >= 0 { + // Truncate generic instantiation name. See issue 48318. + name = name[:i] + } if name == "" { return &UnsupportedTypeError{typ} } |