diff options
| author | Austin Clements <austin@google.com> | 2015-11-18 16:48:22 -0500 |
|---|---|---|
| committer | Austin Clements <austin@google.com> | 2015-12-03 03:53:35 +0000 |
| commit | bb6fb929d6e5c2e401f4e3ebe2b7505845970e4b (patch) | |
| tree | 63033144d562b8de23f226a37448f6245bcb1b34 /src/encoding/xml | |
| parent | 08b80ca880278b2eed519f6227cee12d87090f7f (diff) | |
| download | go-bb6fb929d6e5c2e401f4e3ebe2b7505845970e4b.tar.xz | |
runtime: fix sanity check in stackBarrier
stackBarrier on amd64 sanity checks that it's unwinding the correct
entry in the stack barrier array. However, this check is wrong in two
ways that make it unlikely to catch anything, right or wrong:
1) It checks that savedLRPtr == SP, but, in fact, it should be that
savedLRPtr+8 == SP because the RET that returned to stackBarrier
popped the saved LR. However, we didn't notice this check was wrong
because,
2) the sense of the conditional branch is also wrong.
Fix both of these.
Change-Id: I38ba1f652b0168b5b2c11b81637656241262af7c
Reviewed-on: https://go-review.googlesource.com/17039
Reviewed-by: Russ Cox <rsc@golang.org>
Diffstat (limited to 'src/encoding/xml')
0 files changed, 0 insertions, 0 deletions