diff options
| author | Demi Marie Obenour <demi@invisiblethingslab.com> | 2024-09-03 01:33:29 +0000 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2024-09-04 13:33:11 +0000 |
| commit | 794b0a07483fdae7125f325d34fbea6b40a67885 (patch) | |
| tree | 082e62e4cf6380d9b5ab59a891f7cb421ff63604 /src/encoding/xml/xml_test.go | |
| parent | 6450a988a7ed81e8637c106abb7fbe318011dda8 (diff) | |
| download | go-794b0a07483fdae7125f325d34fbea6b40a67885.tar.xz | |
encoding/xml: allow ]]> in attribute values
This is permitted by the XML specification.
Fixes #68387
Change-Id: Ic4ab5520a08a5a997f1c3d13c6d5f80c0521e45c
GitHub-Last-Rev: 6d2ac307bbd0ba7d50830ad8b879c00cc3a7242b
GitHub-Pull-Request: golang/go#69197
Reviewed-on: https://go-review.googlesource.com/c/go/+/610056
Auto-Submit: Ian Lance Taylor <iant@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Diffstat (limited to 'src/encoding/xml/xml_test.go')
| -rw-r--r-- | src/encoding/xml/xml_test.go | 24 |
1 files changed, 24 insertions, 0 deletions
diff --git a/src/encoding/xml/xml_test.go b/src/encoding/xml/xml_test.go index b2a06a7639..fc3c15eff1 100644 --- a/src/encoding/xml/xml_test.go +++ b/src/encoding/xml/xml_test.go @@ -626,6 +626,30 @@ type item struct { FieldA string } +func TestIssue68387(t *testing.T) { + data := `<item b=']]>'/>` + dec := NewDecoder(strings.NewReader(data)) + var tok1, tok2, tok3 Token + var err error + if tok1, err = dec.RawToken(); err != nil { + t.Fatalf("RawToken() failed: %v", err) + } + if tok2, err = dec.RawToken(); err != nil { + t.Fatalf("RawToken() failed: %v", err) + } + if tok3, err = dec.RawToken(); err != io.EOF || tok3 != nil { + t.Fatalf("Missed EOF") + } + s := StartElement{Name{"", "item"}, []Attr{Attr{Name{"","b"}, "]]>"}}} + if !reflect.DeepEqual(tok1.(StartElement), s) { + t.Error("Wrong start element") + } + e := EndElement{Name{"","item"}} + if tok2.(EndElement) != e { + t.Error("Wrong end element") + } +} + func TestIssue569(t *testing.T) { data := `<item><FieldA>abcd</FieldA></item>` var i item |