diff options
| author | Karel Pazdera <pazderak@gmail.com> | 2017-08-24 00:36:28 +0200 |
|---|---|---|
| committer | Ian Lance Taylor <iant@golang.org> | 2017-08-24 00:55:59 +0000 |
| commit | 6e9e9dfa46e032657af06aaea669e4d2264cb79e (patch) | |
| tree | 968364302d390e72a92a37b87cf99dcf10c85d18 /src/encoding/xml/xml_test.go | |
| parent | 77b4beba2fd892a3f8e9da527fdad031f6ecc613 (diff) | |
| download | go-6e9e9dfa46e032657af06aaea669e4d2264cb79e.tar.xz | |
encoding/xml: improve package based on the suggestions from metalinter
Existing code in encoding/xml packages contains code which breaks
various linter rules (comments, constant and variable naming, variable
shadowing, etc).
Fixes #21578
Change-Id: Id4bd9a9be6d5728ce88fb6efe33030ef943c078c
Reviewed-on: https://go-review.googlesource.com/58210
Reviewed-by: Sam Whited <sam@samwhited.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Sam Whited <sam@samwhited.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Diffstat (limited to 'src/encoding/xml/xml_test.go')
| -rw-r--r-- | src/encoding/xml/xml_test.go | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/encoding/xml/xml_test.go b/src/encoding/xml/xml_test.go index dad6ed98c1..7950ca22c4 100644 --- a/src/encoding/xml/xml_test.go +++ b/src/encoding/xml/xml_test.go @@ -479,15 +479,15 @@ func TestAllScalars(t *testing.T) { } type item struct { - Field_a string + FieldA string } func TestIssue569(t *testing.T) { - data := `<item><Field_a>abcd</Field_a></item>` + data := `<item><FieldA>abcd</FieldA></item>` var i item err := Unmarshal([]byte(data), &i) - if err != nil || i.Field_a != "abcd" { + if err != nil || i.FieldA != "abcd" { t.Fatal("Expecting abcd") } } |