diff options
| author | apocelipes <seve3r@outlook.com> | 2024-04-02 13:41:00 +0000 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2024-04-11 16:40:14 +0000 |
| commit | 08af216c75a583a198c4ccfe68628c74554ee82f (patch) | |
| tree | 3c02d4bd8f1103fec6e353a61028015eae8a3fec /src/encoding/json/decode_test.go | |
| parent | 45703b50a6ae557ebe9bd7b1bea8e49d66fc97ee (diff) | |
| download | go-08af216c75a583a198c4ccfe68628c74554ee82f.tar.xz | |
encoding/json: use slices to simplify the code
Use "slices.Equal" instead of "reflect.DeepEqual".
Replace unnecessary helper type "byIndex" with "slices.SortFunc".
No effect on benchmarks.
Change-Id: I1fb2768ea6d9db7f487408fa109343be3f1741d5
GitHub-Last-Rev: 8429bc145272ae620fcd001b1de393bf3c0b6108
GitHub-Pull-Request: golang/go#66646
Reviewed-on: https://go-review.googlesource.com/c/go/+/575715
Reviewed-by: qiu laidongfeng2 <2645477756@qq.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Diffstat (limited to 'src/encoding/json/decode_test.go')
| -rw-r--r-- | src/encoding/json/decode_test.go | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/encoding/json/decode_test.go b/src/encoding/json/decode_test.go index a10c1e1ebb..f5b44677b3 100644 --- a/src/encoding/json/decode_test.go +++ b/src/encoding/json/decode_test.go @@ -14,6 +14,7 @@ import ( "math/big" "net" "reflect" + "slices" "strconv" "strings" "testing" @@ -1998,7 +1999,7 @@ func TestByteKind(t *testing.T) { if err != nil { t.Fatalf("Unmarshal error: %v", err) } - if !reflect.DeepEqual(got, want) { + if !slices.Equal(got, want) { t.Fatalf("Marshal/Unmarshal mismatch:\n\tgot: %v\n\twant: %v", got, want) } } @@ -2017,7 +2018,7 @@ func TestSliceOfCustomByte(t *testing.T) { if err != nil { t.Fatalf("Unmarshal error: %v", err) } - if !reflect.DeepEqual(got, want) { + if !slices.Equal(got, want) { t.Fatalf("Marshal/Unmarshal mismatch:\n\tgot: %v\n\twant: %v", got, want) } } |