diff options
| author | Rob Pike <r@golang.org> | 2014-10-17 20:51:15 -0700 |
|---|---|---|
| committer | Rob Pike <r@golang.org> | 2014-10-17 20:51:15 -0700 |
| commit | 65dde1ed4b1c71fad6d2b106b779c5191e5f7cd7 (patch) | |
| tree | f64040a4c614c3203b10e39b5678ae66cb91a9d7 /src/encoding/gob/decoder.go | |
| parent | 9965e4022030f56fc241be8934d5e6b95ac84900 (diff) | |
| download | go-65dde1ed4b1c71fad6d2b106b779c5191e5f7cd7.tar.xz | |
encoding/gob: use simple append-only buffer for encoding
Bytes buffers have more API and are a little slower. Since appending
is a key part of the path in encode, using a faster implementation
speeds things up measurably.
The couple of positive swings are likely garbage-collection related
since memory allocation looks different in the benchmark now.
I am not concerned by them.
benchmark old ns/op new ns/op delta
BenchmarkEndToEndPipe 6620 6388 -3.50%
BenchmarkEndToEndByteBuffer 3548 3600 +1.47%
BenchmarkEndToEndSliceByteBuffer 336678 367980 +9.30%
BenchmarkEncodeComplex128Slice 78199 71297 -8.83%
BenchmarkEncodeFloat64Slice 37731 32258 -14.51%
BenchmarkEncodeInt32Slice 26780 22977 -14.20%
BenchmarkEncodeStringSlice 35882 26492 -26.17%
BenchmarkDecodeComplex128Slice 194819 185126 -4.98%
BenchmarkDecodeFloat64Slice 120538 120102 -0.36%
BenchmarkDecodeInt32Slice 106442 107275 +0.78%
BenchmarkDecodeStringSlice 272902 269866 -1.11%
LGTM=ruiu
R=golang-codereviews, ruiu
CC=golang-codereviews
https://golang.org/cl/160990043
Diffstat (limited to 'src/encoding/gob/decoder.go')
| -rw-r--r-- | src/encoding/gob/decoder.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/encoding/gob/decoder.go b/src/encoding/gob/decoder.go index dcad7a0e48..fe1494100a 100644 --- a/src/encoding/gob/decoder.go +++ b/src/encoding/gob/decoder.go @@ -212,7 +212,7 @@ func (dec *Decoder) Decode(e interface{}) error { // Otherwise, it stores the value into v. In that case, v must represent // a non-nil pointer to data or be an assignable reflect.Value (v.CanSet()) // If the input is at EOF, DecodeValue returns io.EOF and -// does not modify e. +// does not modify v. func (dec *Decoder) DecodeValue(v reflect.Value) error { if v.IsValid() { if v.Kind() == reflect.Ptr && !v.IsNil() { |
