diff options
| author | Keith Randall <khr@golang.org> | 2015-06-27 12:57:06 -0700 |
|---|---|---|
| committer | Keith Randall <khr@golang.org> | 2015-06-29 02:54:09 +0000 |
| commit | 214c7a2c43a43fd05e3b94dbc67e7d0082460986 (patch) | |
| tree | e97b5b29656a5fd209cae86ad6d5498862f32a43 /src/encoding/binary/binary.go | |
| parent | 0a6df4a87b8333e1029c1940c84e39fad66352fa (diff) | |
| download | go-214c7a2c43a43fd05e3b94dbc67e7d0082460986.tar.xz | |
cmd/link/internal/ld: exclude only real container symbols from symtab
It looks like the test for whether symbols contain subsymbols is wrong.
In particular, symbols in C libraries are mistakenly considered container
symbols.
Fix the test so only symbols which actually have a subsymbol
are excluded from the symtab. When linking cgo programs the list
of containers is small, something like:
container _/home/khr/sandbox/symtab/misc/cgo/test(.text)<74>
container _/home/khr/sandbox/symtab/misc/cgo/test/issue8828(.text)<75>
container _/home/khr/sandbox/symtab/misc/cgo/test/issue9026(.text)<76>
container runtime/cgo(.text)<77>
I'm not sure this is the right fix. In particular I can't reproduce
the original problem. Anyone have a repro they can try and see if
this fix works?
Fixes #10747
Fixes #11396
Change-Id: Id8b016389d33348b4a791fdcba0f9db8ae71ebf3
Reviewed-on: https://go-review.googlesource.com/11652
Reviewed-by: Russ Cox <rsc@golang.org>
Diffstat (limited to 'src/encoding/binary/binary.go')
0 files changed, 0 insertions, 0 deletions