aboutsummaryrefslogtreecommitdiff
path: root/src/debug
diff options
context:
space:
mode:
authorMatthew Dempsky <mdempsky@google.com>2015-03-05 17:00:18 -0800
committerIan Lance Taylor <iant@golang.org>2015-03-11 21:28:51 +0000
commitd533e3955db945072ab2dfcca1cab57099569260 (patch)
treeb9c5eb73767fc37d2d44b6e73b8ce6d92b745955 /src/debug
parenteb96bb19927f2dea87a3c98bbe82f4984ebe30b4 (diff)
downloadgo-d533e3955db945072ab2dfcca1cab57099569260.tar.xz
cmd/internal/ld: fix package data parsing
The conversion of this logic from C introduced a few subtle behavior changes. E.g., assigning "name := data[p0:]" and then "name = name[:p1-p0]" actually caused name to span the vast majority of the package data, as at the time of the second statement p0 points just after the package name and p1 points to the end of the package data. Similarly, the logic for advancing past the newline at the end of the package line changed slightly: for a "package foo safe" line, the new code would only advance up to the newline, but not past. (Albeit, in practice this doesn't matter: newlines in package data are harmless.) Lastly, "data[p0]" was incorrectly written as "data[0]" a few times. Change-Id: I49017e16ba33a627f773532b418cbf85a84f2b4b Reviewed-on: https://go-review.googlesource.com/7000 Reviewed-by: Ian Lance Taylor <iant@golang.org>
Diffstat (limited to 'src/debug')
0 files changed, 0 insertions, 0 deletions