diff options
| author | Marcel Meyer <mm.marcelmeyer@gmail.com> | 2025-04-14 15:34:30 +0000 |
|---|---|---|
| committer | Robert Griesemer <gri@google.com> | 2025-04-16 12:26:29 -0700 |
| commit | 5715d735590cf545f03b34e58ade83b919e53fba (patch) | |
| tree | a400b36dabbedb30bc662433757df1bd2b807b80 /src/debug | |
| parent | 2cb9e7f68f90ea9119fd4172fc61630279d79d67 (diff) | |
| download | go-5715d735590cf545f03b34e58ade83b919e53fba.tar.xz | |
all: use strings.ReplaceAll where applicable
```
find . \
-not -path './.git/*' \
-not -path './test/*' \
-not -path './src/cmd/vendor/*' \
-not -wholename './src/strings/example_test.go' \
-type f \
-exec \
sed -i -E 's/strings\.Replace\((.+), -1\)/strings\.ReplaceAll\(\1\)/g' {} \;
```
Change-Id: I59e2e91b3654c41a32f17dd91ec56f250198f0d6
GitHub-Last-Rev: 0868b1eccc945ca62a5ed0e56a4054994d4bd659
GitHub-Pull-Request: golang/go#73370
Reviewed-on: https://go-review.googlesource.com/c/go/+/665395
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Keith Randall <khr@golang.org>
Reviewed-by: Robert Griesemer <gri@google.com>
Diffstat (limited to 'src/debug')
| -rw-r--r-- | src/debug/dwarf/line.go | 2 | ||||
| -rw-r--r-- | src/debug/dwarf/line_test.go | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/src/debug/dwarf/line.go b/src/debug/dwarf/line.go index 3a02c8e307..3811416b92 100644 --- a/src/debug/dwarf/line.go +++ b/src/debug/dwarf/line.go @@ -837,7 +837,7 @@ func splitDrive(path string) (drive, rest string) { } if len(path) > 3 && (path[0] == '\\' || path[0] == '/') && (path[1] == '\\' || path[1] == '/') { // Normalize the path so we can search for just \ below. - npath := strings.Replace(path, "/", `\`, -1) + npath := strings.ReplaceAll(path, "/", `\`) // Get the host part, which must be non-empty. slash1 := strings.IndexByte(npath[2:], '\\') + 2 if slash1 > 2 { diff --git a/src/debug/dwarf/line_test.go b/src/debug/dwarf/line_test.go index e947d99ebb..0a7ade934a 100644 --- a/src/debug/dwarf/line_test.go +++ b/src/debug/dwarf/line_test.go @@ -94,8 +94,8 @@ func TestLineGCCWindows(t *testing.T) { toWindows := func(lf *LineFile) *LineFile { lf2 := *lf - lf2.Name = strings.Replace(lf2.Name, "/home/austin/go.dev/", "C:\\workdir\\go\\", -1) - lf2.Name = strings.Replace(lf2.Name, "/", "\\", -1) + lf2.Name = strings.ReplaceAll(lf2.Name, "/home/austin/go.dev/", "C:\\workdir\\go\\") + lf2.Name = strings.ReplaceAll(lf2.Name, "/", "\\") return &lf2 } file1C := toWindows(file1C) |