diff options
| author | Russ Cox <rsc@golang.org> | 2017-11-10 15:58:16 -0500 |
|---|---|---|
| committer | Russ Cox <rsc@golang.org> | 2017-11-16 16:34:35 +0000 |
| commit | 5a7fd4039913f8bdb322b577ecf10a60ddcfedea (patch) | |
| tree | 4aa0d4af14b91d878490872cd6b1199bdc7914d2 /src/database | |
| parent | 8c47aa155f944278c0a79454af35c55528d02c30 (diff) | |
| download | go-5a7fd4039913f8bdb322b577ecf10a60ddcfedea.tar.xz | |
cmd/go: run cover before cgo
If we're running coverage on a package using cgo, we need to
apply both cmd/cover and cmd/cgo as source transformers.
To date we've applied cgo, then cover.
Cover is very sensitive to the exact character position of
expressions in its input, though, and cgo is not, so swap
them, applying first cover and then cgo.
The only drawback here is that coverage formerly applied
to SWIG-generated cgo files, and now it does not.
I am not convinced anyone depended critically on that,
and probably the later analysis with go tool cover would
have tried to parse the original .swig file as a Go file and
gotten very confused.
Fixes #8726.
Fixes #9212.
Fixes #9479.
Change-Id: I777c8b64f7726cb117d59e03073954abc6dfa34d
Reviewed-on: https://go-review.googlesource.com/77155
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Diffstat (limited to 'src/database')
0 files changed, 0 insertions, 0 deletions